firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Turn on win_build_tests_2_3 shard, skip 'build windows' tests (#82386)" (#82396)

Browse Source 
This reverts commit a66e5a7fa08b72016e04fffb735dd911d04b77a1.
This commit is contained in:
godofredoc 2021-05-13 11:56:32 -07:00 committed by GitHub
parent adb3f13819
commit 4924969347
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
dev/bots/test.dart
View File

@ -442,7 +442,8 @@ Future<void> _runExampleProjectBuildTests(FileSystemEntity exampleDirectory) asy
} }
if (Platform.isWindows) { if (Platform.isWindows) {
if (Directory(path.join(examplePath, 'windows')).existsSync()) { if (Directory(path.join(examplePath, 'windows')).existsSync()) {
// TODO(jmagman): Re-add Windows build tests when Visual Studio is available https://github.com/flutter/flutter/issues/81956. await _flutterBuildWin32(examplePath, release: false, additionalArgs: additionalArgs, verifyCaching: verifyCaching);
await _flutterBuildWin32(examplePath, release: true, additionalArgs: additionalArgs, verifyCaching: verifyCaching);
} else { } else {
print('Example project ${path.basename(examplePath)} has no windows directory, skipping Win32'); print('Example project ${path.basename(examplePath)} has no windows directory, skipping Win32');
} }
@ -506,6 +507,21 @@ Future<void> _flutterBuildMacOS(String relativePathToApplication, {
); );
} }
Future<void> _flutterBuildWin32(String relativePathToApplication, {
@required bool release,
bool verifyCaching = false,
List<String> additionalArgs = const <String>[],
}) async {
assert(Platform.isWindows);
await runCommand(flutter, <String>['config', '--enable-windows-desktop']);
print('${green}Testing Windows build$reset for $cyan$relativePathToApplication$reset...');
await _flutterBuild(relativePathToApplication, 'Windows', 'windows',
release: release,
verifyCaching: verifyCaching,
additionalArgs: additionalArgs
);
}
Future<void> _flutterBuild( Future<void> _flutterBuild(
String relativePathToApplication, String relativePathToApplication,
String platformLabel, String platformLabel,

2
dev/try_builders.json
View File

@ -579,7 +579,7 @@
"name": "Windows build_tests_2_3", "name": "Windows build_tests_2_3",
"repo": "flutter", "repo": "flutter",
"task_name": "win_build_tests_2_3", "task_name": "win_build_tests_2_3",
"enabled": true "enabled": false
}, },
{ {
"name": "Windows build_tests_3_3", "name": "Windows build_tests_3_3",