firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix TextField/CupertinoTextField hint style overflow not work. (#114335)

Browse Source 
* fix text field hint style overflow not work, keep default ellipsis.

* fix cupertino text field hint style overflow not work, keep default ellipsis.

* add Cupertino placeholder style test.
This commit is contained in:
陈昱 2022-11-08 01:45:56 +08:00 committed by GitHub
parent 496cf627e6
commit 497a52809d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/cupertino/text_field.dart
View File

@ -1133,7 +1133,7 @@ class _CupertinoTextFieldState extends State<CupertinoTextField> with Restoratio
child: Text(
widget.placeholder!,
maxLines: widget.maxLines,
overflow: TextOverflow.ellipsis,
overflow: placeholderStyle.overflow ?? TextOverflow.ellipsis,
style: placeholderStyle,
textAlign: widget.textAlign,
),

25
packages/flutter/test/cupertino/text_field_test.dart
View File

@ -7485,4 +7485,29 @@ void main() {
expect(controller.text, cutValue);
}
});
testWidgets('placeholder style overflow works', (WidgetTester tester) async {
final String placeholder = 'hint text' * 20;
const TextStyle placeholderStyle = TextStyle(
fontFamily: 'Ahem',
fontSize: 14.0,
overflow: TextOverflow.fade,
);
await tester.pumpWidget(
CupertinoApp(
home: Center(
child: CupertinoTextField(
placeholder: placeholder,
placeholderStyle: placeholderStyle,
),
),
),
);
await tester.pumpAndSettle();
final Finder placeholderFinder = find.text(placeholder);
final Text placeholderWidget = tester.widget(placeholderFinder);
expect(placeholderWidget.overflow, placeholderStyle.overflow);
expect(placeholderWidget.style!.overflow, placeholderStyle.overflow);
});
}