firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate python invocations to python3 (#87759)

Browse Source 
Python 2 has been end-of-life'd since January 2020, all Python scripts
on which Flutter depends have been migrated to Python 3. This changes
documentation and remaining invocations to explicitly invoke python3.

Issue: https://github.com/flutter/flutter/issues/83043
This commit is contained in:
Chris Bracken 2021-08-06 14:42:08 -07:00 committed by GitHub
parent bffa11e2b6
commit 497eb13d03
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/bots/README.md
View File

@ -47,7 +47,7 @@ To run `prepare_package.dart` locally:
- Make sure the `depot_tools` is in your `PATH`. If you're on Windows, you also need - Make sure the `depot_tools` is in your `PATH`. If you're on Windows, you also need
an environment variable called `DEPOT_TOOLS` with the path to `depot_tools` as value. an environment variable called `DEPOT_TOOLS` with the path to `depot_tools` as value.
- Run `gsutil.py config` (or `python %DEPOT_TOOLS%\gsutil.py` on Windows) to - Run `gsutil.py config` (or `python3 %DEPOT_TOOLS%\gsutil.py` on Windows) to
authenticate with your auth token. authenticate with your auth token.
- Create a local temp directory. `cd` into it. - Create a local temp directory. `cd` into it.
- Run `dart [path to your normal Flutter repo]/dev/bots/prepare_package.dart - Run `dart [path to your normal Flutter repo]/dev/bots/prepare_package.dart

2
dev/bots/prepare_package.dart
View File

@ -669,7 +669,7 @@ class ArchivePublisher {
} }
if (platform.isWindows) { if (platform.isWindows) {
return _processRunner.runProcess( return _processRunner.runProcess(
<String>['python', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args], <String>['python3', path.join(platform.environment['DEPOT_TOOLS']!, 'gsutil.py'), '--', ...args],
workingDirectory: workingDirectory, workingDirectory: workingDirectory,
failOk: failOk, failOk: failOk,
); );

2
dev/bots/test/prepare_package_test.dart
View File

@ -289,7 +289,7 @@ void main() {
late FakeProcessManager processManager; late FakeProcessManager processManager;
late Directory tempDir; late Directory tempDir;
final String gsutilCall = platform.isWindows final String gsutilCall = platform.isWindows
? 'python ${path.join("D:", "depot_tools", "gsutil.py")}' ? 'python3 ${path.join("D:", "depot_tools", "gsutil.py")}'
: 'gsutil.py'; : 'gsutil.py';
final String releasesName = 'releases_$platformName.json'; final String releasesName = 'releases_$platformName.json';
final String archiveName = platform.isLinux ? 'archive.tar.xz' : 'archive.zip'; final String archiveName = platform.isLinux ? 'archive.tar.xz' : 'archive.zip';