firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] dont create temp vec for discard. (flutter/engine#56759)

Browse Source 
This can have at most 3 entries so just use an array to avoid heap allocation.
This commit is contained in:
Jonah Williams 2024-11-22 12:26:11 -08:00 committed by GitHub
parent a8b975b315
commit 4a17eac8a1
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc
View File

@ -492,7 +492,8 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
} }
if (gl.DiscardFramebufferEXT.IsAvailable()) { if (gl.DiscardFramebufferEXT.IsAvailable()) {
std::vector<GLenum> attachments; std::array<GLenum, 3> attachments;
size_t attachment_count = 0;
// TODO(130048): discarding stencil or depth on the default fbo causes Angle // TODO(130048): discarding stencil or depth on the default fbo causes Angle
// to discard the entire render target. Until we know the reason, default to // to discard the entire render target. Until we know the reason, default to
@ -500,21 +501,21 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
bool angle_safe = gl.GetCapabilities()->IsANGLE() ? !is_default_fbo : true; bool angle_safe = gl.GetCapabilities()->IsANGLE() ? !is_default_fbo : true;
if (pass_data.discard_color_attachment) { if (pass_data.discard_color_attachment) {
attachments.push_back(is_default_fbo ? GL_COLOR_EXT attachments[attachment_count++] =
: GL_COLOR_ATTACHMENT0); (is_default_fbo ? GL_COLOR_EXT : GL_COLOR_ATTACHMENT0);
} }
if (pass_data.discard_depth_attachment && angle_safe) { if (pass_data.discard_depth_attachment && angle_safe) {
attachments.push_back(is_default_fbo ? GL_DEPTH_EXT attachments[attachment_count++] =
: GL_DEPTH_ATTACHMENT); (is_default_fbo ? GL_DEPTH_EXT : GL_DEPTH_ATTACHMENT);
} }
if (pass_data.discard_stencil_attachment && angle_safe) { if (pass_data.discard_stencil_attachment && angle_safe) {
attachments.push_back(is_default_fbo ? GL_STENCIL_EXT attachments[attachment_count++] =
: GL_STENCIL_ATTACHMENT); (is_default_fbo ? GL_STENCIL_EXT : GL_STENCIL_ATTACHMENT);
} }
gl.DiscardFramebufferEXT(GL_FRAMEBUFFER, // target gl.DiscardFramebufferEXT(GL_FRAMEBUFFER, // target
attachments.size(), // attachments to discard attachment_count, // attachments to discard
attachments.data() // size attachments.data() // size
); );
} }