firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixes RawDialogRoute memory leak (#147817)

Browse Source 
part of #141198 

- Fixes memory leak on `RawDialogRoute`
- Adds opt-in test
This commit is contained in:
Dimil Kalathiya 2024-05-08 05:09:56 +05:30 committed by GitHub
parent 1fee18760e
commit 4abd7352f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/widgets/routes.dart
View File

@ -2286,10 +2286,7 @@ class RawDialogRoute<T> extends PopupRoute<T> {
if (_transitionBuilder == null) { if (_transitionBuilder == null) {
// Some default transition. // Some default transition.
return FadeTransition( return FadeTransition(
opacity: CurvedAnimation( opacity: animation,
parent: animation,
curve: Curves.linear,
),
child: child, child: child,
); );
} }

6
packages/flutter/test/widgets/routes_test.dart
View File

@ -8,6 +8,7 @@ import 'dart:ui';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
import 'semantics_tester.dart'; import 'semantics_tester.dart';
@ -974,7 +975,10 @@ void main() {
expect(secondaryAnimationOfRouteOne.value, primaryAnimationOfRouteTwo.value); expect(secondaryAnimationOfRouteOne.value, primaryAnimationOfRouteTwo.value);
}); });
testWidgets('showGeneralDialog handles transparent barrier color', (WidgetTester tester) async { testWidgets('showGeneralDialog handles transparent barrier color',
// TODO(polina-c): remove when fixed https://github.com/flutter/flutter/issues/145600 [leak-tracking-opt-in]
experimentalLeakTesting: LeakTesting.settings.withTracked(classes: <String>['CurvedAnimation']),
(WidgetTester tester) async {
await tester.pumpWidget(MaterialApp( await tester.pumpWidget(MaterialApp(
home: Builder( home: Builder(
builder: (BuildContext context) { builder: (BuildContext context) {