firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't crash when importing a module that doesn't export

Browse Source 
Instead of crashing, we should use the value "undefined". There's some question
as to whether we should default to the document, but we can resolve that later.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/690483002
This commit is contained in:
Adam Barth 2014-10-28 14:13:31 -07:00
parent 28626cf782
commit 4c5a9b1775
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/tests/modules/import-without-export-expected.txt Normal file
View File

@ -0,0 +1 @@
PASS

9
engine/src/flutter/tests/modules/import-without-export.sky Normal file
View File

@ -0,0 +1,9 @@
<html>
<link rel="import" href="resources/does-not-export.sky" as="hello" />
<link rel="import" href="../resources/dump-as-text.sky" />
<div id="result">FAIL - Script did not execute</div>
<script>
document.getElementById("result").textContent =
hello === undefined ? "PASS" : "FAIL";
</script>
</html>

1
engine/src/flutter/tests/modules/resources/does-not-export.sky Normal file
View File

@ -0,0 +1 @@
This module has no exports.