firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean-up viewId casts in flutter_test (#128256)

Browse Source 
Follow-up to https://github.com/flutter/engine/pull/42493.
This commit is contained in:
Michael Goderbauer 2023-06-06 10:23:17 -07:00 committed by GitHub
parent ffab83e6f3
commit 4c5db40ff5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_test/lib/src/window.dart
View File

@ -678,8 +678,7 @@ class TestFlutterView implements FlutterView {
final TestDisplay _display;
@override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands.
int get viewId => _view.viewId as int; // ignore: unnecessary_cast
int get viewId => _view.viewId;
/// The device pixel ratio to use for this test.
///
@ -2089,8 +2088,7 @@ class TestWindow implements SingletonFlutterWindow {
'This feature was deprecated after v3.9.0-0.1.pre.'
)
@override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands.
int get viewId => _view.viewId as int; // ignore: unnecessary_cast
int get viewId => _view.viewId;
/// This gives us some grace time when the dart:ui side adds something to
/// [SingletonFlutterWindow], and makes things easier when we do rolls to give