firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix divide-by-zero crash in animation_bench benchmark (#137539)

Browse Source 
If the benchmark runs out of time before it closes the drawer it is animating, it tries to divide by zero when computing the time per frame.

Don't report time per frame for activities with zero frames. This likely only happens for the close frame action, but guards are added to all time per frame computations in this benchmark.
This commit is contained in:
William Hesse 2023-10-31 16:10:53 +01:00 committed by GitHub
parent 0d3cf281c4
commit 4d0c487f6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
dev/benchmarks/microbenchmarks/lib/stocks/animation_bench.dart
View File

@ -83,23 +83,29 @@ Future<void> main() async {
unit: 's',
name: 'stock_animation_total_run_time',
);
printer.addResult(
description: ' Opening first frame average time',
value: totalOpenFrameElapsedMicroseconds / totalOpenIterationCount,
unit: 'µs per frame ($totalOpenIterationCount frames)',
name: 'stock_animation_open_first_frame_average',
);
printer.addResult(
description: ' Closing first frame average time',
value: totalCloseFrameElapsedMicroseconds / totalCloseIterationCount,
unit: 'µs per frame ($totalCloseIterationCount frames)',
name: 'stock_animation_close_first_frame_average',
);
printer.addResult(
description: ' Subsequent frames average time',
value: totalSubsequentFramesElapsedMicroseconds / totalSubsequentFramesIterationCount,
unit: 'µs per frame ($totalSubsequentFramesIterationCount frames)',
name: 'stock_animation_subsequent_frame_average',
);
if (totalOpenIterationCount > 0) {
printer.addResult(
description: ' Opening first frame average time',
value: totalOpenFrameElapsedMicroseconds / totalOpenIterationCount,
unit: 'µs per frame ($totalOpenIterationCount frames)',
name: 'stock_animation_open_first_frame_average',
);
}
if (totalCloseIterationCount > 0) {
printer.addResult(
description: ' Closing first frame average time',
value: totalCloseFrameElapsedMicroseconds / totalCloseIterationCount,
unit: 'µs per frame ($totalCloseIterationCount frames)',
name: 'stock_animation_close_first_frame_average',
);
}
if (totalSubsequentFramesIterationCount > 0) {
printer.addResult(
description: ' Subsequent frames average time',
value: totalSubsequentFramesElapsedMicroseconds / totalSubsequentFramesIterationCount,
unit: 'µs per frame ($totalSubsequentFramesIterationCount frames)',
name: 'stock_animation_subsequent_frame_average',
);
}
printer.printToStdout();
}