From 4e27f3472cb2017cc87d2a0e9e6072934ceca6c5 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Fri, 16 Feb 2024 18:13:22 -0800 Subject: [PATCH] [Impeller] skip perspective transformed text goldens. (#143623) Part of https://github.com/flutter/flutter/issues/143616 The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine. --- packages/flutter/test/cupertino/date_picker_test.dart | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/flutter/test/cupertino/date_picker_test.dart b/packages/flutter/test/cupertino/date_picker_test.dart index d378c6b897..9a358ccf59 100644 --- a/packages/flutter/test/cupertino/date_picker_test.dart +++ b/packages/flutter/test/cupertino/date_picker_test.dart @@ -15,6 +15,8 @@ import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; import 'package:flutter_test/flutter_test.dart'; +import '../impeller_test_helpers.dart'; + // TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785 const bool skipPerspectiveTextGoldens = isBrowser; @@ -1607,7 +1609,7 @@ void main() { matchesGoldenFile('date_picker_test.datetime.drag.png'), ); } - }); + }, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616 testWidgets('DatePicker displays the date in correct order', (WidgetTester tester) async { await tester.pumpWidget( @@ -1752,7 +1754,7 @@ void main() { matchesGoldenFile('timer_picker_test.datetime.drag.png'), ); } - }); + }, skip: impellerEnabled); // https://github.com/flutter/flutter/issues/143616 testWidgets('TimerPicker only changes hour label after scrolling stops', (WidgetTester tester) async { Duration? duration;