firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Dismissible]Fix a state lose issue (#108971)

Browse Source
This commit is contained in:
xubaolin 2022-08-19 10:47:10 +08:00 committed by GitHub
parent 4293ce9a5c
commit 4e2b648069
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/widgets/dismissible.dart
View File

@ -323,6 +323,8 @@ class _DismissibleState extends State<Dismissible> with TickerProviderStateMixin
Size? _sizePriorToCollapse;
bool _dismissThresholdReached = false;
final GlobalKey _contentKey = GlobalKey();
@override
bool get wantKeepAlive => (_moveController?.isAnimating ?? false) || (_resizeController?.isAnimating ?? false);
@ -668,7 +670,7 @@ class _DismissibleState extends State<Dismissible> with TickerProviderStateMixin
Widget content = SlideTransition(
position: _moveAnimation,
child: widget.child,
child: KeyedSubtree(key: _contentKey, child: widget.child),
);
if (background != null) {

1
packages/flutter/test/material/debug_test.dart
View File

@ -329,6 +329,7 @@ void main() {
' PhysicalModel\n'
' AnimatedPhysicalModel\n'
' Material\n'
' KeyedSubtree-[GlobalKey#00000]\n'
' FractionalTranslation\n'
' SlideTransition\n'
' Listener\n'

28
packages/flutter/test/widgets/dismissible_test.dart
View File

@ -1150,4 +1150,32 @@ void main() {
expect(reportedDismissUpdatePreviousReached, false);
expect(reportedDismissUpdateProgress, 0.0);
});
testWidgets('Change direction does not lose child state', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/108961
Widget buildFrame(DismissDirection direction) {
return Directionality(
textDirection: TextDirection.ltr,
child: Dismissible(
dragStartBehavior: DragStartBehavior.down,
direction: direction,
key: const Key('Dismissible'),
resizeDuration: null,
child: const SizedBox(
width: 100.0,
height: 100.0,
child: Text('I Love Flutter!'),
),
),
);
}
await tester.pumpWidget(buildFrame(DismissDirection.horizontal));
final RenderBox textRenderObjectBegin = tester.renderObject(find.text('I Love Flutter!'));
await tester.pumpWidget(buildFrame(DismissDirection.none));
final RenderBox textRenderObjectEnd = tester.renderObject(find.text('I Love Flutter!'));
expect(identical(textRenderObjectBegin, textRenderObjectEnd), true);
});
}