firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Navigator.pop before PopupMenuItem onTap call (#127446)

Browse Source 
*The order of calling Navigator.pop and PopupMenuItem.onTap has been changed so before calling PopupMenuItem onTap method, PopupMenuBotton onSelect method is going to be called.*

*Solves #127443*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
This commit is contained in:
Mahdi Bagheri 2023-06-09 01:55:38 +03:30 committed by GitHub
parent ceeaf98e64
commit 4e9869b925
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 45 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter/lib/src/material/popup_menu.dart
View File

@ -339,9 +339,10 @@ class PopupMenuItemState<T, W extends PopupMenuItem<T>> extends State<W> {
/// the menu route.
@protected
void handleTap() {
widget.onTap?.call();
// Need to pop the navigator first in case onTap may push new route onto navigator.
Navigator.pop<T>(context, widget.value);
widget.onTap?.call();
}
@override

42
packages/flutter/test/material/popup_menu_test.dart
View File

@ -3260,6 +3260,48 @@ void main() {
final Offset menuTopLeft = tester.getTopLeft(find.bySemanticsLabel('Popup menu'));
expect(childBottomLeft, menuTopLeft);
});
testWidgets('PopupmenuItem onTap should be calling after Navigator.pop', (WidgetTester tester) async {
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
appBar: AppBar(
actions: <Widget>[
PopupMenuButton<int>(
itemBuilder: (BuildContext context) => <PopupMenuItem<int>>[
PopupMenuItem<int>(
onTap: () {
showModalBottomSheet(
context: context,
builder: (BuildContext context) {
return const SizedBox(
height: 200.0,
child: Center(child: Text('ModalBottomSheet')),
);
},
);
},
value: 10,
child: const Text('ACTION'),
),
],
),
],
),
),
),
);
await tester.tap(find.byType(PopupMenuButton<int>));
await tester.pumpAndSettle();
await tester.tap(find.text('ACTION'));
await tester.pumpAndSettle();
// Verify that the ModalBottomSheet is displayed
final Finder modalBottomSheet = find.text('ModalBottomSheet');
expect(modalBottomSheet, findsOneWidget);
});
}
class TestApp extends StatelessWidget {