Give error on too many arguments to flutter config (#121494)

Give error on too many arguments to `flutter config`
This commit is contained in:
Greg Price 2023-02-27 09:22:20 -08:00 committed by GitHub
parent a297cb368b
commit 516b60bda1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 0 deletions

View File

@ -101,6 +101,16 @@ class ConfigCommand extends FlutterCommand {
@override
Future<FlutterCommandResult> runCommand() async {
final List<String> rest = argResults?.rest ?? <String>[];
if (rest.isNotEmpty) {
throwToolExit(exitCode: 2,
'error: flutter config: Too many arguments.\n'
'\n'
'If a value has a space in it, enclose in quotes on the command line\n'
'to make a single argument. For example:\n'
' flutter config --android-studio-dir "/opt/Android Studio"');
}
if (boolArgDeprecated('machine')) {
await handleMachine();
return FlutterCommandResult.success();

View File

@ -44,6 +44,19 @@ void main() {
}
group('config', () {
testUsingContext('throws error on excess arguments', () {
final ConfigCommand configCommand = ConfigCommand();
final CommandRunner<void> commandRunner = createTestCommandRunner(configCommand);
expect(() => commandRunner.run(<String>[
'config',
'--android-studio-dir=/opt/My', 'Android', 'Studio',
]), throwsToolExit());
verifyNoAnalytics();
}, overrides: <Type, Generator>{
Usage: () => testUsage,
});
testUsingContext('machine flag', () async {
final ConfigCommand command = ConfigCommand();
await command.handleMachine();