firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Inline some element methods for better stack overflow affinity (#78269)

Browse Source
This commit is contained in:
Michael Goderbauer 2021-03-29 13:34:04 -07:00 committed by GitHub
parent c4ba26e31b
commit 5231a7dc59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/widgets/framework.dart
View File

@ -3310,6 +3310,7 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
/// ///
/// See the [RenderObjectElement] documentation for more information on slots. /// See the [RenderObjectElement] documentation for more information on slots.
@protected @protected
@pragma('vm:prefer-inline')
Element? updateChild(Element? child, Widget? newWidget, Object? newSlot) { Element? updateChild(Element? child, Widget? newWidget, Object? newSlot) {
if (newWidget == null) { if (newWidget == null) {
if (child != null) if (child != null)
@ -3583,6 +3584,7 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
/// The element returned by this function will already have been mounted and /// The element returned by this function will already have been mounted and
/// will be in the "active" lifecycle state. /// will be in the "active" lifecycle state.
@protected @protected
@pragma('vm:prefer-inline')
Element inflateWidget(Widget newWidget, Object? newSlot) { Element inflateWidget(Widget newWidget, Object? newSlot) {
assert(newWidget != null); assert(newWidget != null);
final Key? key = newWidget.key; final Key? key = newWidget.key;
@ -4236,6 +4238,7 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
/// Called by the [BuildOwner] when [BuildOwner.scheduleBuildFor] has been /// Called by the [BuildOwner] when [BuildOwner.scheduleBuildFor] has been
/// called to mark this element dirty, by [mount] when the element is first /// called to mark this element dirty, by [mount] when the element is first
/// built, and by [update] when the widget has changed. /// built, and by [update] when the widget has changed.
@pragma('vm:prefer-inline')
void rebuild() { void rebuild() {
assert(_lifecycleState != _ElementLifecycle.initial); assert(_lifecycleState != _ElementLifecycle.initial);
if (_lifecycleState != _ElementLifecycle.active || !_dirty) if (_lifecycleState != _ElementLifecycle.active || !_dirty)