firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] use ES3 extension for external images. (flutter/engine#57018)

Browse Source 
The shader language level is 300 or more we need to use GL_OES_EGL_image_external_essl3 instead of GL_OES_EGL_image_external
This commit is contained in:
Jonah Williams 2024-12-09 10:25:00 -08:00 committed by GitHub
parent 15af0c4f83
commit 529d0d6757
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
engine/src/flutter/impeller/compiler/compiler.cc
View File

@ -26,6 +26,12 @@
namespace impeller { namespace impeller {
namespace compiler { namespace compiler {
namespace {
constexpr const char* kEGLImageExternalExtension = "GL_OES_EGL_image_external";
constexpr const char* kEGLImageExternalExtension300 =
"GL_OES_EGL_image_external_essl3";
} // namespace
static uint32_t ParseMSLVersion(const std::string& msl_version) { static uint32_t ParseMSLVersion(const std::string& msl_version) {
std::stringstream sstream(msl_version); std::stringstream sstream(msl_version);
std::string version_part; std::string version_part;
@ -147,7 +153,11 @@ static CompilerBackend CreateGLSLCompiler(const spirv_cross::ParsedIR& ir,
// incompatible with ES 310+. // incompatible with ES 310+.
for (auto& id : ir.ids_for_constant_or_variable) { for (auto& id : ir.ids_for_constant_or_variable) {
if (StringStartsWith(ir.get_name(id), kExternalTexturePrefix)) { if (StringStartsWith(ir.get_name(id), kExternalTexturePrefix)) {
gl_compiler->require_extension("GL_OES_EGL_image_external"); if (source_options.gles_language_version >= 300) {
gl_compiler->require_extension(kEGLImageExternalExtension300);
} else {
gl_compiler->require_extension(kEGLImageExternalExtension);
}
break; break;
} }
} }