firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleanup empty statements.

Browse Source 
The new `empty_statements` lint (in the next DEV roll), flags these empty statements.  Harmless, except the one in `basic.dart` that fixes a real-life bug. :)
This commit is contained in:
pq 2016-06-28 13:42:22 -07:00
parent 1a5ca2f675
commit 543f705adb
9 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter/lib/src/painting/box_painter.dart
View File

@ -272,7 +272,8 @@ class Border {
} }
canvas.drawPath(path, paint); canvas.drawPath(path, paint);
break; break;
case BorderStyle.none: ; case BorderStyle.none:
break;
} }
switch (right.style) { switch (right.style) {
@ -290,7 +291,8 @@ class Border {
} }
canvas.drawPath(path, paint); canvas.drawPath(path, paint);
break; break;
case BorderStyle.none: ; case BorderStyle.none:
break;
} }
switch (bottom.style) { switch (bottom.style) {
@ -308,7 +310,8 @@ class Border {
} }
canvas.drawPath(path, paint); canvas.drawPath(path, paint);
break; break;
case BorderStyle.none: ; case BorderStyle.none:
break;
} }
switch (left.style) { switch (left.style) {
@ -326,7 +329,8 @@ class Border {
} }
canvas.drawPath(path, paint); canvas.drawPath(path, paint);
break; break;
case BorderStyle.none: ; case BorderStyle.none:
break;
} }
} }

2
packages/flutter/lib/src/rendering/flow.dart
View File

@ -335,7 +335,7 @@ class RenderFlow extends RenderBox
void painter(PaintingContext context, Offset offset) { void painter(PaintingContext context, Offset offset) {
context.paintChild(child, offset); context.paintChild(child, offset);
}; }
if (opacity == 1.0) { if (opacity == 1.0) {
_paintingContext.pushTransform(needsCompositing, _paintingOffset, transform, painter); _paintingContext.pushTransform(needsCompositing, _paintingOffset, transform, painter);
} else { } else {

2
packages/flutter/lib/src/rendering/object.dart
View File

@ -871,7 +871,7 @@ class PipelineOwner {
for (RenderObject node in dirtyNodes..sort((RenderObject a, RenderObject b) => b.depth - a.depth)) { for (RenderObject node in dirtyNodes..sort((RenderObject a, RenderObject b) => b.depth - a.depth)) {
if (node._needsPaint && node.owner == this) if (node._needsPaint && node.owner == this)
PaintingContext.repaintCompositedChild(node); PaintingContext.repaintCompositedChild(node);
}; }
assert(_nodesNeedingPaint.length == 0); assert(_nodesNeedingPaint.length == 0);
} finally { } finally {
_debugDoingPaint = false; _debugDoingPaint = false;

4
packages/flutter/lib/src/widgets/basic.dart
View File

@ -2756,9 +2756,9 @@ class Semantics extends SingleChildRenderObjectWidget {
void debugFillDescription(List<String> description) { void debugFillDescription(List<String> description) {
super.debugFillDescription(description); super.debugFillDescription(description);
description.add('container: $container'); description.add('container: $container');
if (checked != null); if (checked != null)
description.add('checked: $checked'); description.add('checked: $checked');
if (label != null); if (label != null)
description.add('label: "$label"'); description.add('label: "$label"');
} }
} }

2
packages/flutter/test/widget/lazy_block_viewport_test.dart
View File

@ -170,7 +170,7 @@ void main() {
void collectText(Widget widget) { void collectText(Widget widget) {
if (widget is Text) if (widget is Text)
text.add(widget.data); text.add(widget.data);
}; }
Widget builder() { Widget builder() {
return new LazyBlockViewport( return new LazyBlockViewport(

2
packages/flutter/test/widget/set_state_2_test.dart
View File

@ -39,7 +39,7 @@ void main() {
} }
)); ));
log.add('---'); log.add('---');
await tester.tap(find.text('inner'));; await tester.tap(find.text('inner'));
await tester.pump(); await tester.pump();
log.add('---'); log.add('---');
expect(log, equals(<String>[ expect(log, equals(<String>[

2
packages/flutter_sprites/test/node_test.dart
View File

@ -167,7 +167,7 @@ void main() {
{ {
Node rootNode = new Node(); Node rootNode = new Node();
Node node0 = new Node()..zPosition = -1.0;; Node node0 = new Node()..zPosition = -1.0;
Node node1 = new Node(); Node node1 = new Node();
Node node2 = new Node()..zPosition = 1.0; Node node2 = new Node()..zPosition = 1.0;

2
packages/flutter_tools/lib/src/commands/build_apk.dart
View File

@ -461,7 +461,7 @@ Future<int> buildAndroid(
String targetPath = entity.path.substring(assetsDir.path.length); String targetPath = entity.path.substring(assetsDir.path.length);
extraFiles["assets/$targetPath"] = entity; extraFiles["assets/$targetPath"] = entity;
} }
}; }
} }
// In debug (JIT) mode, the snapshot lives in the FLX, and we can skip the APK // In debug (JIT) mode, the snapshot lives in the FLX, and we can skip the APK

2
packages/flutter_tools/lib/src/ios/simulators.dart
View File

@ -660,7 +660,7 @@ class IOSSimulator extends Device {
String name = path.basename(entity.path); String name = path.basename(entity.path);
return entity is File && name.startsWith('Simulator') && name.endsWith('.png'); return entity is File && name.startsWith('Simulator') && name.endsWith('.png');
})); }));
}; }
Set<File> existingScreenshots = getScreenshots(); Set<File> existingScreenshots = getScreenshots();