firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid calling cancel on AnsiSpinner more than once when building for iOS (#26826)

Browse Source 
* Avoid calling cancel more than once

* add some missing checks for ansispinner
This commit is contained in:
Dan Field 2019-01-21 22:41:35 -08:00 committed by GitHub
parent 386f3466b5
commit 543f8924b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/ios/mac.dart
View File

@ -467,7 +467,8 @@ Future<XcodeBuildResult> buildXcodeProject({
return;
}
} else {
initialBuildStatus.cancel();
initialBuildStatus?.cancel();
initialBuildStatus = null;
buildSubStatus = logger.startProgress(
line,
timeout: kSlowOperation,
@ -494,7 +495,9 @@ Future<XcodeBuildResult> buildXcodeProject({
// Notifies listener that no more output is coming.
scriptOutputPipeFile?.writeAsStringSync('all done');
buildSubStatus?.stop();
buildSubStatus = null;
initialBuildStatus?.cancel();
initialBuildStatus = null;
buildStopwatch.stop();
printStatus(
'Xcode build done.'.padRight(kDefaultStatusPadding + 1)