firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove dynamic calls (#125238)

Browse Source 
I don't know what I was thinking when I wrote this code back in 2017 but this is so trivially fixable...
This commit is contained in:
Ian Hickson 2023-04-20 13:09:12 -07:00 committed by GitHub
parent 9caabdd220
commit 55825f166e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter/lib/src/widgets/overscroll_indicator.dart
View File

@ -261,14 +261,10 @@ class _GlowingOverscrollIndicatorState extends State<GlowingOverscrollIndicator>
} }
} }
} }
} else if (notification is ScrollEndNotification || notification is ScrollUpdateNotification) { } else if ((notification is ScrollEndNotification && notification.dragDetails != null) ||
// Using dynamic here to avoid layer violations of importing (notification is ScrollUpdateNotification && notification.dragDetails != null)) {
// drag_details.dart from gestures. _leadingController!.scrollEnd();
// ignore: avoid_dynamic_calls _trailingController!.scrollEnd();
if ((notification as dynamic).dragDetails != null) {
_leadingController!.scrollEnd();
_trailingController!.scrollEnd();
}
} }
_lastNotificationType = notification.runtimeType; _lastNotificationType = notification.runtimeType;
return false; return false;