firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve debugging when dart pub get call fails (#112968)

Browse Source
This commit is contained in:
Christopher Fujino 2022-10-05 14:53:06 -07:00 committed by GitHub
parent 2c0d43e723
commit 559d524ec1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/dart/pub.dart
View File

@ -418,7 +418,10 @@ class _DefaultPub implements Pub {
status?.cancel(); status?.cancel();
if (exception is io.ProcessException) { if (exception is io.ProcessException) {
final StringBuffer buffer = StringBuffer('${exception.message}\n'); final StringBuffer buffer = StringBuffer('${exception.message}\n');
buffer.writeln('Working directory: "$directory"'); final String directoryExistsMessage = _fileSystem.directory(directory).existsSync()
? 'exists'
: 'does not exist';
buffer.writeln('Working directory: "$directory" ($directoryExistsMessage)');
final Map<String, String> env = await _createPubEnvironment(context, flutterRootOverride); final Map<String, String> env = await _createPubEnvironment(context, flutterRootOverride);
buffer.write(_stringifyPubEnv(env)); buffer.write(_stringifyPubEnv(env));
throw io.ProcessException( throw io.ProcessException(

2
packages/flutter_tools/test/general.shard/dart/pub_get_test.dart
View File

@ -782,7 +782,7 @@ last line of pub output: "err3"
isA<ProcessException>().having( isA<ProcessException>().having(
(ProcessException error) => error.message, (ProcessException error) => error.message,
'message', 'message',
contains('Working directory: "/"'), contains('Working directory: "/" (exists)'),
).having( ).having(
(ProcessException error) => error.message, (ProcessException error) => error.message,
'message', 'message',