From 55f257e39ea481602030632ec115b9a8ba60611d Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Thu, 20 Mar 2025 17:08:03 -0700 Subject: [PATCH] Skip `/api/update-task-status` on Devicelab (#165614) Mitigates https://github.com/flutter/flutter/issues/165610. If this works, we can likely not only fix the tree status, but delete code from Cocoon (and dev/devicelab). Yay! --- dev/devicelab/lib/command/upload_results.dart | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/dev/devicelab/lib/command/upload_results.dart b/dev/devicelab/lib/command/upload_results.dart index 958e308150..34a963c6eb 100644 --- a/dev/devicelab/lib/command/upload_results.dart +++ b/dev/devicelab/lib/command/upload_results.dart @@ -53,8 +53,8 @@ class UploadResultsCommand extends Command { @override Future run() async { final String? resultsPath = argResults!['results-file'] as String?; - final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?; - final String? testFlakyStatus = argResults!['test-flaky'] as String?; + // final String? serviceAccountTokenFile = argResults!['service-account-token-file'] as String?; + // final String? testFlakyStatus = argResults!['test-flaky'] as String?; final String? gitBranch = argResults!['git-branch'] as String?; final String? builderName = argResults!['luci-builder'] as String?; final String? testStatus = argResults!['test-status'] as String?; @@ -69,14 +69,17 @@ class UploadResultsCommand extends Command { print('Successfully uploaded metrics to skia perf'); } - final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile); - return cocoon.sendTaskStatus( - resultsPath: resultsPath, - isTestFlaky: testFlakyStatus == 'True', - gitBranch: gitBranch, - builderName: builderName, - testStatus: testStatus, - builderBucket: builderBucket, + print( + 'Intentionally skipping /api/update-task-status ($gitBranch/$builderName/$testStatus/$builderBucket) because yjbanov@ said so', ); + // final Cocoon cocoon = Cocoon(serviceAccountTokenPath: serviceAccountTokenFile); + // return cocoon.sendTaskStatus( + // resultsPath: resultsPath, + // isTestFlaky: testFlakyStatus == 'True', + // gitBranch: gitBranch, + // builderName: builderName, + // testStatus: testStatus, + // builderBucket: builderBucket, + // ); } }