firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TODO Audits - 1 (#53604)

Browse Source
This commit is contained in:
Kate Lovett 2020-03-31 11:21:01 -07:00 committed by GitHub
parent 9b6fd7cb0b
commit 560c72287b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 4 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev/benchmarks/complex_layout/android/app/build.gradle
View File

@ -39,14 +39,6 @@ android {
signingConfig signingConfigs.debug signingConfig signingConfigs.debug
} }
} }
aaptOptions {
// TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
if(System.getenv("FLUTTER_CI_WIN")) {
println "AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
cruncherEnabled false
}
}
} }
flutter { flutter {

8
dev/benchmarks/platform_views_layout/android/app/build.gradle
View File

@ -39,14 +39,6 @@ android {
signingConfig signingConfigs.debug signingConfig signingConfigs.debug
} }
} }
aaptOptions {
// TODO(goderbauer): remove when https://github.com/flutter/flutter/issues/8986 is resolved.
if(System.getenv("FLUTTER_CI_WIN")) {
println "AAPT cruncher disabled when running on CI, see https://github.com/flutter/flutter/issues/8986"
cruncherEnabled false
}
}
} }
flutter { flutter {

2
dev/benchmarks/test_apps/stocks/lib/stock_data.dart
View File

@ -19,7 +19,7 @@ class Stock {
Stock(this.symbol, this.name, this.lastSale, this.marketCap, this.percentChange); Stock(this.symbol, this.name, this.lastSale, this.marketCap, this.percentChange);
Stock.fromFields(List<String> fields) { Stock.fromFields(List<String> fields) {
// FIXME: This class should only have static data, not lastSale, etc. // TODO(jackson): This class should only have static data, not lastSale, etc.
// "Symbol","Name","LastSale","MarketCap","IPOyear","Sector","industry","Summary Quote", // "Symbol","Name","LastSale","MarketCap","IPOyear","Sector","industry","Summary Quote",
lastSale = 0.0; lastSale = 0.0;
try { try {

1
dev/devicelab/lib/framework/framework.dart
View File

@ -97,7 +97,6 @@ class _TaskRunner {
for (final RunningProcessInfo info in afterRunningDartInstances) { for (final RunningProcessInfo info in afterRunningDartInstances) {
if (!beforeRunningDartInstances.contains(info)) { if (!beforeRunningDartInstances.contains(info)) {
print('$info was leaked by this test.'); print('$info was leaked by this test.');
// TODO(dnfield): remove this special casing after https://github.com/flutter/flutter/issues/29141 is resolved.
if (result is TaskResultCheckProcesses) { if (result is TaskResultCheckProcesses) {
result = TaskResult.failure('This test leaked dart processes'); result = TaskResult.failure('This test leaked dart processes');
} }

5
dev/devicelab/lib/framework/running_processes.dart
View File

@ -27,7 +27,7 @@ class RunningProcessInfo {
@override @override
int get hashCode { int get hashCode {
// TODO(dnfield): Replace this when Object.hashValues lands. // TODO(dnfield): Replace this when Object.hashValues lands, https://github.com/dart-lang/sdk/issues/11617
int hash = 17; int hash = 17;
if (pid != null) { if (pid != null) {
hash = hash * 23 + pid.hashCode; hash = hash * 23 + pid.hashCode;
@ -88,8 +88,7 @@ Stream<RunningProcessInfo> windowsRunningProcesses(String processName) async* {
? '"Get-CimInstance Win32_Process -Filter \\"name=\'$processName\'\\" | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"' ? '"Get-CimInstance Win32_Process -Filter \\"name=\'$processName\'\\" | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"'
: '"Get-CimInstance Win32_Process | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"'; : '"Get-CimInstance Win32_Process | Select-Object ProcessId,CreationDate,CommandLine | Format-Table -AutoSize | Out-String -Width 4096"';
// Unfortunately, there doesn't seem to be a good way to get ProcessManager to // Unfortunately, there doesn't seem to be a good way to get ProcessManager to
// run this. May be a bug in Dart. // run this.
// TODO(dnfield): fix this when https://github.com/dart-lang/sdk/issues/36175 is resolved.
final ProcessResult result = await Process.run( final ProcessResult result = await Process.run(
'powershell -command $script', 'powershell -command $script',
<String>[], <String>[],

2
dev/devicelab/manifest.yaml
View File

@ -584,7 +584,7 @@ tasks:
stage: devicelab_ios stage: devicelab_ios
required_agent_capabilities: ["mac/ios"] required_agent_capabilities: ["mac/ios"]
# TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/41133 # TODO(fujino): does not pass on iOS13 https://github.com/flutter/flutter/issues/43029
# system_debug_ios: # system_debug_ios:
# description: > # description: >
# Tests that the Engine correctly initializes the system debugger for debug-mode iOS apps. # Tests that the Engine correctly initializes the system debugger for debug-mode iOS apps.