add analysis_options.yaml to dev/conductor (#90005)

dev/conductor/analysis_options.yaml

@@ -0,0 +1,16 @@
+# Use the analysis options settings from the top level of the repo (not
+# the ones from above, which include the `public_member_api_docs` rule).
+
+include: ../../analysis_options.yaml
+
+analyzer:
+  exclude:
+      # Ignore protoc generated files
+    - "lib/proto/*"
+linter:
+  rules:
+    avoid_catches_without_on_clauses: true
+    curly_braces_in_flow_control_structures: true
+    library_private_types_in_public_api: false # Tool does not have any public API
+    prefer_relative_imports: true
+    unawaited_futures: true

dev/conductor/lib/git.dart

@@ -63,10 +63,12 @@ class Git {
     } else {
       message.writeln('Command "git ${args.join(' ')}" failed to $explanation.');
     }
-    if ((result.stdout as String).isNotEmpty)
+    if ((result.stdout as String).isNotEmpty) {
       message.writeln('stdout from git:\n${result.stdout}\n');
-    if ((result.stderr as String).isNotEmpty)
+    }
+    if ((result.stderr as String).isNotEmpty) {
       message.writeln('stderr from git:\n${result.stderr}\n');
+    }
     throw GitException(message.toString());
   }
 }