From 5a23a2a3c4b08d3e13662191f1996fd316282ab9 Mon Sep 17 00:00:00 2001
From: Matan Lurey <matanlurey@users.noreply.github.com>
Date: Mon, 6 Jan 2025 13:43:47 -0800
Subject: [PATCH] Remove now-unnecessary command `felt analyze`. (#160986)

Closes https://github.com/flutter/flutter/issues/154143.

The entire engine sub-repo is now checked for Dart analysis issues, so a
separate command is not needed.
---
 .../ci/builders/linux_web_engine_test.json    |  7 ---
 .../src/flutter/lib/web_ui/dev/analyze.dart   | 62 -------------------
 engine/src/flutter/lib/web_ui/dev/felt.dart   |  2 -
 .../lib/web_ui/dev/generate_builder_json.dart |  5 --
 4 files changed, 76 deletions(-)
 delete mode 100644 engine/src/flutter/lib/web_ui/dev/analyze.dart

diff --git a/engine/src/flutter/ci/builders/linux_web_engine_test.json b/engine/src/flutter/ci/builders/linux_web_engine_test.json
index 4e8e55c2ca..3404294f76 100644
--- a/engine/src/flutter/ci/builders/linux_web_engine_test.json
+++ b/engine/src/flutter/ci/builders/linux_web_engine_test.json
@@ -194,13 +194,6 @@
             "check-licenses"
           ],
           "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "web engine analysis",
-          "parameters": [
-            "analyze"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
         }
       ]
     },
diff --git a/engine/src/flutter/lib/web_ui/dev/analyze.dart b/engine/src/flutter/lib/web_ui/dev/analyze.dart
deleted file mode 100644
index efb943543b..0000000000
--- a/engine/src/flutter/lib/web_ui/dev/analyze.dart
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2013 The Flutter Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import 'dart:async';
-
-import 'package:args/command_runner.dart';
-
-import 'environment.dart';
-import 'pipeline.dart';
-import 'utils.dart';
-
-class AnalyzeCommand extends Command<bool> with ArgUtils<bool> {
-  @override
-  String get name => 'analyze';
-
-  @override
-  String get description => 'Analyze the Flutter web engine.';
-
-  @override
-  FutureOr<bool> run() async {
-    final Pipeline buildPipeline = Pipeline(steps: <PipelineStep>[PubGetStep(), AnalyzeStep()]);
-    await buildPipeline.run();
-    return true;
-  }
-}
-
-/// Runs `dart pub get`.
-class PubGetStep extends ProcessStep {
-  @override
-  String get description => 'pub get';
-
-  @override
-  bool get isSafeToInterrupt => true;
-
-  @override
-  Future<ProcessManager> createProcess() {
-    print('Running `dart pub get`...');
-    return startProcess(environment.dartExecutable, <String>[
-      'pub',
-      'get',
-    ], workingDirectory: environment.webUiRootDir.path);
-  }
-}
-
-/// Runs `dart analyze --fatal-infos`.
-class AnalyzeStep extends ProcessStep {
-  @override
-  String get description => 'analyze';
-
-  @override
-  bool get isSafeToInterrupt => true;
-
-  @override
-  Future<ProcessManager> createProcess() {
-    print('Running `dart analyze`...');
-    return startProcess(environment.dartExecutable, <String>[
-      'analyze',
-      '--fatal-infos',
-    ], workingDirectory: environment.webUiRootDir.path);
-  }
-}
diff --git a/engine/src/flutter/lib/web_ui/dev/felt.dart b/engine/src/flutter/lib/web_ui/dev/felt.dart
index 9126355789..5366895679 100644
--- a/engine/src/flutter/lib/web_ui/dev/felt.dart
+++ b/engine/src/flutter/lib/web_ui/dev/felt.dart
@@ -6,7 +6,6 @@ import 'dart:io' as io;
 
 import 'package:args/command_runner.dart';
 
-import 'analyze.dart';
 import 'build.dart';
 import 'clean.dart';
 import 'exceptions.dart';
@@ -18,7 +17,6 @@ import 'utils.dart';
 
 CommandRunner<bool> runner =
     CommandRunner<bool>('felt', 'Command-line utility for building and testing Flutter web engine.')
-      ..addCommand(AnalyzeCommand())
       ..addCommand(BuildCommand())
       ..addCommand(CleanCommand())
       ..addCommand(RollFallbackFontsCommand())
diff --git a/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart b/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
index d667bb36e3..5d8800560c 100644
--- a/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
+++ b/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
@@ -117,11 +117,6 @@ class GenerateBuilderJsonCommand extends Command<bool> {
           'parameters': <String>['check-licenses'],
           'script': 'flutter/lib/web_ui/dev/felt',
         },
-        <String, dynamic>{
-          'name': 'web engine analysis',
-          'parameters': <String>['analyze'],
-          'script': 'flutter/lib/web_ui/dev/felt',
-        },
       ],
     };
   }