Initial pass to cleanup dom.dart to use newer JS interop styles (flutter/engine#54093)

Browse Source

This only addresses the following:

- Removes `JSVoid` in favor of `void`. `JSVoid`, which is just a
typedef, should be deprecated and removed eventually.
- Removes extra interop methods that were needed to make sure arity was
correct. These are no longer needed as interop methods are
invocation-sensitive and calls to them do not forward more arguments
than were passed by the user.
- Removes unnecessary annotations on extensions.

Still left to do (not comprehensive):

- Migrate to extension types.
- Remove forwarding methods that are only used to convert primitives in
favor of changing the interop method to include the Dart primitive type.
It might be a bit slower in dart2wasm to do this, but will need to
verify and fix it if that's the case.
- Remove usage of `js_util`.
- See if we can replace types with their `package:web` equivalent for
easier maintenance.

...

This commit is contained in:

Srujan Gaddam 2024-07-25 13:10:31 -07:00 committed by GitHub

parent d02386554a

commit 5ba4b01dfe

1 changed files with 169 additions and 226 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

395

engine/src/flutter/lib/web_ui/lib/src/engine/dom.dart

File diff suppressed because it is too large Load Diff