firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] fix device buffer nullptr on Intel macOS. (#160645)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/159278

macOS intel devices uses MTLResourceStorageModeManaged which is still
host visible
This commit is contained in:
Jonah Williams 2024-12-22 10:11:21 -08:00 committed by GitHub
parent cb40d94055
commit 5c7d9d01ba
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/impeller/renderer/backend/metal/device_buffer_mtl.mm
View File

@ -23,9 +23,17 @@ id<MTLBuffer> DeviceBufferMTL::GetMTLBuffer() const {
} }
uint8_t* DeviceBufferMTL::OnGetContents() const { uint8_t* DeviceBufferMTL::OnGetContents() const {
#if !FML_OS_IOS
if (storage_mode_ != MTLStorageModeShared &&
storage_mode_ != MTLResourceStorageModeManaged) {
return nullptr;
}
#else
if (storage_mode_ != MTLStorageModeShared) { if (storage_mode_ != MTLStorageModeShared) {
return nullptr; return nullptr;
} }
#endif // !FML_OS_IOS
return reinterpret_cast<uint8_t*>(buffer_.contents); return reinterpret_cast<uint8_t*>(buffer_.contents);
} }