firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] Decouple fatal-warnings check from fatal-infos (#113748)

Browse Source
This commit is contained in:
Lucas Britto 2022-10-26 20:44:25 +04:00 committed by GitHub
parent d988c11a87
commit 5d93894264
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/commands/analyze_once.dart
View File

@ -167,8 +167,7 @@ class AnalyzeOnce extends AnalyzeBase {
if (severityLevel == AnalysisSeverity.error) {
return true;
}
if (severityLevel == AnalysisSeverity.warning &&
(argResults['fatal-warnings'] as bool || argResults['fatal-infos'] as bool)) {
if (severityLevel == AnalysisSeverity.warning && argResults['fatal-warnings'] as bool) {
return true;
}
if (severityLevel == AnalysisSeverity.info && argResults['fatal-infos'] as bool) {

26
packages/flutter_tools/test/integration.shard/analyze_once_test.dart
View File

@ -339,7 +339,7 @@ int analyze() {}
);
});
testWithoutContext('analyze once only fatal-infos has warning issue finally exit code 1.', () async {
testWithoutContext('analyze once only fatal-infos has warning issue finally exit code 0.', () async {
const String warningSourceCode = '''
int analyze() {}
''';
@ -359,6 +359,30 @@ analyzer:
'missing_return',
],
exitMessageContains: '1 issue found.',
);
});
testWithoutContext('analyze once only fatal-warnings has warning issue finally exit code 1.', () async {
const String warningSourceCode = '''
int analyze() {}
''';
final File optionsFile = fileSystem.file(fileSystem.path.join(projectPath, 'analysis_options.yaml'));
optionsFile.writeAsStringSync('''
analyzer:
errors:
missing_return: warning
''');
fileSystem.directory(projectPath).childFile('main.dart').writeAsStringSync(warningSourceCode);
await runCommand(
arguments: <String>['analyze','--no-pub', '--no-fatal-infos', '--fatal-warnings'],
statusTextContains: <String>[
'warning',
'missing_return',
],
exitMessageContains: '1 issue found.',
exitCode: 1,
);
});