firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Support failures-only and silent reporters in flutter test (#148739)

Browse Source 
Fixes #148738.

Also add some tests for this part of the `flutter test` CLI.
This commit is contained in:
Greg Price 2024-06-03 12:44:39 -07:00 committed by GitHub
parent 691a18df5f
commit 5e448f4ce5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 61 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter_tools/lib/src/commands/test.dart
View File

@ -216,12 +216,14 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
..addOption('reporter',
abbr: 'r',
help: 'Set how to print test results. If unset, value will default to either compact or expanded.',
allowed: <String>['compact', 'expanded', 'github', 'json'],
allowed: <String>['compact', 'expanded', 'failures-only', 'github', 'json', 'silent'],
allowedHelp: <String, String>{
'compact': 'A single line that updates dynamically (The default reporter).',
'compact': 'A single line, updated continuously (the default).',
'expanded': 'A separate line for each update. May be preferred when logging to a file or in continuous integration.',
'failures-only': 'A separate line for failing tests, with no output for passing tests.',
'github': 'A custom reporter for GitHub Actions (the default reporter when running on GitHub Actions).',
'json': 'A machine-readable format. See: https://dart.dev/go/test-docs/json_reporter.md',
'silent': 'A reporter with no output. May be useful when only the exit code is meaningful.'
},
)
..addOption('file-reporter',

57
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View File

@ -283,6 +283,63 @@ dev_dependencies:
});
});
group('--reporter/-r', () {
String? passedReporter(List<String> args) {
final int i = args.indexOf('-r');
if (i < 0) {
expect(args, isNot(contains('--reporter')));
expect(args, isNot(contains(matches(RegExp(r'^(-r|--reporter=)')))));
return null;
} else {
return args[i+1];
}
}
Future<void> expectPassesReporter(String value) async {
final FakePackageTest fakePackageTest = FakePackageTest();
final TestCommand testCommand = TestCommand(testWrapper: fakePackageTest);
final CommandRunner<void> commandRunner = createTestCommandRunner(testCommand);
await commandRunner.run(<String>['test', '--no-pub', '-r', value]);
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
await commandRunner.run(<String>['test', '--no-pub', '-r$value']);
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
await commandRunner.run(<String>['test', '--no-pub', '--reporter', value]);
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
await commandRunner.run(<String>['test', '--no-pub', '--reporter=$value']);
expect(passedReporter(fakePackageTest.lastArgs!), equals(value));
}
testUsingContext('accepts valid values and passes them through', () async {
await expectPassesReporter('compact');
await expectPassesReporter('expanded');
await expectPassesReporter('failures-only');
await expectPassesReporter('github');
await expectPassesReporter('json');
await expectPassesReporter('silent');
}, overrides: <Type, Generator>{
FileSystem: () => fs,
ProcessManager: () => FakeProcessManager.any(),
Cache: () => Cache.test(processManager: FakeProcessManager.any()),
});
testUsingContext('by default, passes no reporter', () async {
final FakePackageTest fakePackageTest = FakePackageTest();
final TestCommand testCommand = TestCommand(testWrapper: fakePackageTest);
final CommandRunner<void> commandRunner = createTestCommandRunner(testCommand);
await commandRunner.run(<String>['test', '--no-pub']);
expect(passedReporter(fakePackageTest.lastArgs!), isNull);
}, overrides: <Type, Generator>{
FileSystem: () => fs,
ProcessManager: () => FakeProcessManager.any(),
Cache: () => Cache.test(processManager: FakeProcessManager.any()),
});
});
testUsingContext('Supports coverage and machine', () async {
final FakePackageTest fakePackageTest = FakePackageTest();