firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow nullable tweens in TweenAnimationBuilder (#72476)

Browse Source
This commit is contained in:
Michael Goderbauer 2020-12-23 12:09:02 -08:00 committed by GitHub
parent 15c009b805
commit 5eabfc2447
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/widgets/tween_animation_builder.dart
View File

@ -113,7 +113,7 @@ import 'value_listenable_builder.dart';
/// [AnimatedBuilder], which can be used similarly to this /// [AnimatedBuilder], which can be used similarly to this
/// [TweenAnimationBuilder], but unlike the latter it is powered by a /// [TweenAnimationBuilder], but unlike the latter it is powered by a
/// developer-managed [AnimationController]. /// developer-managed [AnimationController].
class TweenAnimationBuilder<T extends Object> extends ImplicitlyAnimatedWidget { class TweenAnimationBuilder<T extends Object?> extends ImplicitlyAnimatedWidget {
/// Creates a [TweenAnimationBuilder]. /// Creates a [TweenAnimationBuilder].
/// ///
/// The properties [tween], [duration], and [builder] are required. The values /// The properties [tween], [duration], and [builder] are required. The values
@ -194,7 +194,7 @@ class TweenAnimationBuilder<T extends Object> extends ImplicitlyAnimatedWidget {
} }
} }
class _TweenAnimationBuilderState<T extends Object> extends AnimatedWidgetBaseState<TweenAnimationBuilder<T>> { class _TweenAnimationBuilderState<T extends Object?> extends AnimatedWidgetBaseState<TweenAnimationBuilder<T>> {
Tween<T>? _currentTween; Tween<T>? _currentTween;
@override @override

17
packages/flutter/test/widgets/tween_animation_builder_test.dart
View File

@ -387,4 +387,21 @@ void main() {
await tester.pump(const Duration(seconds: 2)); await tester.pump(const Duration(seconds: 2));
expect(values, everyElement(300)); expect(values, everyElement(300));
}); });
testWidgets('Works with nullable tweens', (WidgetTester tester) async {
final List<Size?> values = <Size?>[];
await tester.pumpWidget(
TweenAnimationBuilder<Size?>(
duration: const Duration(seconds: 1),
tween: SizeTween(end: const Size(10,10)),
builder: (BuildContext context, Size? s, Widget? child) {
values.add(s);
return const Placeholder();
},
),
);
expect(values, <Size>[const Size(10,10)]);
await tester.pump(const Duration(seconds: 2));
expect(values, <Size>[const Size(10,10)]);
});
} }