diff --git a/dev/bots/suite_runners/run_skp_generator_tests.dart b/dev/bots/suite_runners/run_skp_generator_tests.dart new file mode 100644 index 0000000000..5907a98b96 --- /dev/null +++ b/dev/bots/suite_runners/run_skp_generator_tests.dart @@ -0,0 +1,36 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'dart:io'; + +import 'package:path/path.dart' as path; + +import '../run_command.dart'; +import '../utils.dart'; + +/// Runs the skp_generator from the flutter/tests repo. +/// +/// See also the customer_tests shard. +/// +/// Generated SKPs are ditched, this just verifies that it can run without failure. +Future skpGeneratorTestsRunner() async { + printProgress('${green}Running skp_generator from flutter/tests$reset'); + final Directory checkout = Directory.systemTemp.createTempSync('flutter_skp_generator.'); + await runCommand( + 'git', + [ + '-c', + 'core.longPaths=true', + 'clone', + 'https://github.com/flutter/tests.git', + '.', + ], + workingDirectory: checkout.path, + ); + await runCommand( + './build.sh', + const [], + workingDirectory: path.join(checkout.path, 'skp_generator'), + ); +} diff --git a/dev/bots/test.dart b/dev/bots/test.dart index 2623ae9fb4..84faee8de2 100644 --- a/dev/bots/test.dart +++ b/dev/bots/test.dart @@ -50,9 +50,9 @@ import 'dart:convert'; import 'dart:core' as system show print; import 'dart:core' hide print; +import 'dart:io' as io; import 'dart:io' as system show exit; import 'dart:io' hide exit; -import 'dart:io' as io; import 'dart:math' as math; import 'dart:typed_data'; @@ -65,6 +65,7 @@ import 'package:process/process.dart'; import 'run_command.dart'; import 'suite_runners/run_add_to_app_life_cycle_tests.dart'; +import 'suite_runners/run_skp_generator_tests.dart'; import 'suite_runners/run_web_long_running_tests.dart'; import 'tool_subsharding.dart'; import 'utils.dart'; @@ -248,7 +249,7 @@ Future main(List args) async { // All web integration tests 'web_long_running_tests': () => webLongRunningTestsRunner(flutterRoot), 'flutter_plugins': _runFlutterPackagesTests, - 'skp_generator': _runSkpGeneratorTests, + 'skp_generator': skpGeneratorTestsRunner, 'realm_checker': _runRealmCheckerTest, 'customer_testing': _runCustomerTesting, 'analyze': _runAnalyze, @@ -1735,32 +1736,6 @@ Future hasExpectedEntitlements( return passes; } -/// Runs the skp_generator from the flutter/tests repo. -/// -/// See also the customer_tests shard. -/// -/// Generated SKPs are ditched, this just verifies that it can run without failure. -Future _runSkpGeneratorTests() async { - printProgress('${green}Running skp_generator from flutter/tests$reset'); - final Directory checkout = Directory.systemTemp.createTempSync('flutter_skp_generator.'); - await runCommand( - 'git', - [ - '-c', - 'core.longPaths=true', - 'clone', - 'https://github.com/flutter/tests.git', - '.', - ], - workingDirectory: checkout.path, - ); - await runCommand( - './build.sh', - [ ], - workingDirectory: path.join(checkout.path, 'skp_generator'), - ); -} - Future _runRealmCheckerTest() async { final String engineRealm = File(engineRealmFile).readAsStringSync().trim(); if (engineRealm.isNotEmpty) {