From 5ed3b418a159de697da812affe728e69dd77ab5c Mon Sep 17 00:00:00 2001 From: jmagman Date: Wed, 7 Aug 2019 18:02:06 -0700 Subject: [PATCH] Add COMPILER_INDEX_STORE_ENABLE=NO to macOS build and tests (#37806) --- dev/devicelab/bin/tasks/module_test_ios.dart | 2 ++ packages/flutter_tools/lib/src/macos/build_macos.dart | 1 + .../test/general.shard/commands/build_macos_test.dart | 1 + 3 files changed, 4 insertions(+) diff --git a/dev/devicelab/bin/tasks/module_test_ios.dart b/dev/devicelab/bin/tasks/module_test_ios.dart index b01129e7a8..f82ff36559 100644 --- a/dev/devicelab/bin/tasks/module_test_ios.dart +++ b/dev/devicelab/bin/tasks/module_test_ios.dart @@ -250,6 +250,7 @@ Future main() async { 'CODE_SIGN_IDENTITY=-', 'EXPANDED_CODE_SIGN_IDENTITY=-', 'CONFIGURATION_BUILD_DIR=${tempDir.path}', + 'COMPILER_INDEX_STORE_ENABLE=NO', ], environment: { 'FLUTTER_ANALYTICS_LOG_FILE': analyticsOutputFile.path, @@ -294,6 +295,7 @@ Future main() async { 'CODE_SIGN_IDENTITY=-', 'EXPANDED_CODE_SIGN_IDENTITY=-', 'CONFIGURATION_BUILD_DIR=${tempDir.path}', + 'COMPILER_INDEX_STORE_ENABLE=NO', ], canFail: true ); diff --git a/packages/flutter_tools/lib/src/macos/build_macos.dart b/packages/flutter_tools/lib/src/macos/build_macos.dart index 0d5b086ac8..95fa007671 100644 --- a/packages/flutter_tools/lib/src/macos/build_macos.dart +++ b/packages/flutter_tools/lib/src/macos/build_macos.dart @@ -54,6 +54,7 @@ Future buildMacOS({ '-derivedDataPath', flutterBuildDir.absolute.path, 'OBJROOT=${fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Intermediates.noindex')}', 'SYMROOT=${fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Products')}', + 'COMPILER_INDEX_STORE_ENABLE=NO', ]); final Status status = logger.startProgress( 'Building macOS application...', diff --git a/packages/flutter_tools/test/general.shard/commands/build_macos_test.dart b/packages/flutter_tools/test/general.shard/commands/build_macos_test.dart index e9310ccf9c..fcf1819ab1 100644 --- a/packages/flutter_tools/test/general.shard/commands/build_macos_test.dart +++ b/packages/flutter_tools/test/general.shard/commands/build_macos_test.dart @@ -97,6 +97,7 @@ void main() { '-derivedDataPath', flutterBuildDir.absolute.path, 'OBJROOT=${fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Intermediates.noindex')}', 'SYMROOT=${fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Products')}', + 'COMPILER_INDEX_STORE_ENABLE=NO', ])).thenAnswer((Invocation invocation) async { fs.file(fs.path.join('macos', 'Flutter', 'ephemeral', '.app_filename')) ..createSync(recursive: true)