firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove WEB_SHARD_COUNT, which no longer exists post-Cirrus. (#161527)

Browse Source 
Towards https://github.com/flutter/flutter/issues/161387.
This commit is contained in:
Matan Lurey 2025-01-13 12:21:00 -08:00 committed by GitHub
parent 432843a0f3
commit 607c79cdfd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
dev/bots/suite_runners/run_web_tests.dart
View File

@ -82,19 +82,14 @@ class WebTestsSuite {
], ],
}; };
/// The number of Cirrus jobs that run Web tests in parallel. /// The number of jobs that run Web tests in parallel.
/// ///
/// The default is 8 shards. Typically .cirrus.yml would define the /// This used to use the `WEB_SHARD_COUNT` environment variable, but that
/// WEB_SHARD_COUNT environment variable rather than relying on the default. /// was never re-added in the migration to LUCI, so instead the count is
/// /// hardcoded below.
/// WARNING: if you change this number, also change .cirrus.yml
/// and make sure it runs _all_ shards.
/// ///
/// The last shard also runs the Web plugin tests. /// The last shard also runs the Web plugin tests.
int get webShardCount => int get webShardCount => 8;
Platform.environment.containsKey('WEB_SHARD_COUNT')
? int.parse(Platform.environment['WEB_SHARD_COUNT']!)
: 8;
static const List<String> _kAllBuildModes = <String>['debug', 'profile', 'release']; static const List<String> _kAllBuildModes = <String>['debug', 'profile', 'release'];
@ -696,7 +691,7 @@ class WebTestsSuite {
// The last shard also runs the flutter_web_plugins tests. // The last shard also runs the flutter_web_plugins tests.
// //
// We make sure the last shard ends in _last so it's easier to catch mismatches // We make sure the last shard ends in _last so it's easier to catch mismatches
// between `.cirrus.yml` and `test.dart`. // between `.ci.yaml` and `test.dart`.
subshards['${webShardCount - 1}_last'] = () async { subshards['${webShardCount - 1}_last'] = () async {
await _runFlutterWebTest( await _runFlutterWebTest(
webRenderer, webRenderer,