From 607d7934c728afef9a6cc8d329b6f50b3c479466 Mon Sep 17 00:00:00 2001 From: Jenn Magder Date: Tue, 2 Nov 2021 21:23:01 -0700 Subject: [PATCH] Add Help menu to macOS create template (#92946) --- .../flutter_gallery/macos/Runner/Base.lproj/MainMenu.xib | 4 ++++ .../flutter_gallery/macos/RunnerTests/RunnerTests.m | 5 ++++- .../app_shared/macos.tmpl/Runner/Base.lproj/MainMenu.xib | 4 ++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dev/integration_tests/flutter_gallery/macos/Runner/Base.lproj/MainMenu.xib b/dev/integration_tests/flutter_gallery/macos/Runner/Base.lproj/MainMenu.xib index 537341abf9..80e867a4e0 100644 --- a/dev/integration_tests/flutter_gallery/macos/Runner/Base.lproj/MainMenu.xib +++ b/dev/integration_tests/flutter_gallery/macos/Runner/Base.lproj/MainMenu.xib @@ -323,6 +323,10 @@ + + + + diff --git a/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m b/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m index f790ea74e1..80dba8485a 100644 --- a/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m +++ b/dev/integration_tests/flutter_gallery/macos/RunnerTests/RunnerTests.m @@ -24,7 +24,10 @@ XCTAssertGreaterThanOrEqual([mainMenu itemWithTitle:@"View"].submenu.numberOfItems, 1); XCTAssertGreaterThanOrEqual([mainMenu itemWithTitle:@"Window"].submenu.numberOfItems, 1); - XCTAssertNil(NSApplication.sharedApplication.helpMenu); + NSMenu *helpMenu = NSApplication.sharedApplication.helpMenu; + XCTAssertNotNil(helpMenu); + // Only the help menu search text box. + XCTAssertEqual(helpMenu.numberOfItems, 0); } @end diff --git a/packages/flutter_tools/templates/app_shared/macos.tmpl/Runner/Base.lproj/MainMenu.xib b/packages/flutter_tools/templates/app_shared/macos.tmpl/Runner/Base.lproj/MainMenu.xib index 537341abf9..80e867a4e0 100644 --- a/packages/flutter_tools/templates/app_shared/macos.tmpl/Runner/Base.lproj/MainMenu.xib +++ b/packages/flutter_tools/templates/app_shared/macos.tmpl/Runner/Base.lproj/MainMenu.xib @@ -323,6 +323,10 @@ + + + +