firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pass ServiceProvider and ServiceProvider& params in Connect

Browse Source 
In preperation for removing the Client annotation from ServiceProvider
this passes a second parameter of type ServiceProvider in the shell and
application Connect calls. In this patch the type signatures are updated
but the second parameter is basically unused. The intention is that the
first parameter |services| will be used for the connecting application to
request services from the connected application (as it does currently)
and the second parameter |exported_services| be used for the connecting
application to provide services to the connected application. We have
very few services exported in the second direction today - I'll update
them to use the second parameter in a follow-up patch.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/845593003
This commit is contained in:
James Robinson 2015-01-14 14:33:07 -08:00
parent 3ab6eab14c
commit 6179aceb5e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/compositor/surface_holder.cc
View File

@ -20,7 +20,7 @@ SurfaceHolder::SurfaceHolder(Client* client, mojo::Shell* shell)
: client_(client), id_namespace_(0u), local_id_(0u), weak_factory_(this) { : client_(client), id_namespace_(0u), local_id_(0u), weak_factory_(this) {
mojo::ServiceProviderPtr service_provider; mojo::ServiceProviderPtr service_provider;
shell->ConnectToApplication("mojo:surfaces_service", shell->ConnectToApplication("mojo:surfaces_service",
mojo::GetProxy(&service_provider)); mojo::GetProxy(&service_provider), nullptr);
mojo::ConnectToService(service_provider.get(), &surface_); mojo::ConnectToService(service_provider.get(), &surface_);
surface_.set_client(this); surface_.set_client(this);
} }