firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update create templates to 1.0.0 (#65234)

Browse Source
This commit is contained in:
xster 2020-09-10 12:57:56 -07:00 committed by GitHub
parent 330db46da1
commit 65ae30c8cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dev/devicelab/lib/tasks/integration_tests.dart
View File

@ -92,8 +92,20 @@ TaskFunction createFlutterCreateOfflineTest() {
return () async { return () async {
final Directory tempDir = Directory.systemTemp.createTempSync('flutter_create_test.'); final Directory tempDir = Directory.systemTemp.createTempSync('flutter_create_test.');
String output; String output;
// The default create template has an actual online dependency against
// a pub package. Make sure it's available in pub cache first before
// trying to resolve it offline.
await inDirectory(tempDir, () async { await inDirectory(tempDir, () async {
output = await eval(path.join(flutterDirectory.path, 'bin', 'flutter'), <String>['create', '--offline', 'flutter_create_test']); output = await eval(
path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['pub', 'cache', 'add', 'cupertino_icons', '--version', '1.0.0'],
);
});
await inDirectory(tempDir, () async {
output = await eval(
path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['create', '--offline', 'flutter_create_test'],
);
}); });
if (output.contains(RegExp('building flutter tool', caseSensitive: false))) { if (output.contains(RegExp('building flutter tool', caseSensitive: false))) {
return TaskResult.failure('`flutter create --offline` should not rebuild flutter tool'); return TaskResult.failure('`flutter create --offline` should not rebuild flutter tool');

2
packages/flutter_tools/templates/app/pubspec.yaml.tmpl
View File

@ -38,7 +38,7 @@ dependencies:
# The following adds the Cupertino Icons font to your application. # The following adds the Cupertino Icons font to your application.
# Use with the CupertinoIcons class for iOS style icons. # Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.3 cupertino_icons: ^1.0.0
dev_dependencies: dev_dependencies:
flutter_test: flutter_test:

2
packages/flutter_tools/templates/module/common/pubspec.yaml.tmpl
View File

@ -26,7 +26,7 @@ dependencies:
# The following adds the Cupertino Icons font to your application. # The following adds the Cupertino Icons font to your application.
# Use with the CupertinoIcons class for iOS style icons. # Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^0.1.3 cupertino_icons: ^1.0.0
dev_dependencies: dev_dependencies:
flutter_test: flutter_test: