firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show Search Button on keyboard for search widget (#19011)

Browse Source 
Also:
 * Export TextInputAction from `text_field.dart` to parallel `TextInputType`.
This commit is contained in:
Michael Goderbauer 2018-07-03 00:38:16 +02:00 committed by GitHub
parent 1cd09e54a9
commit 6636da40f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/search.dart
View File

@ -412,11 +412,11 @@ class _SearchPageState<T> extends State<_SearchPage<T>> {
textTheme: theme.primaryTextTheme, textTheme: theme.primaryTextTheme,
brightness: theme.primaryColorBrightness, brightness: theme.primaryColorBrightness,
leading: widget.delegate.buildLeading(context), leading: widget.delegate.buildLeading(context),
// TODO(goderbauer): Show the search key (instead of enter) on keyboard, https://github.com/flutter/flutter/issues/17525
title: new TextField( title: new TextField(
controller: queryTextController, controller: queryTextController,
focusNode: widget.delegate._focusNode, focusNode: widget.delegate._focusNode,
style: theme.textTheme.title, style: theme.textTheme.title,
textInputAction: TextInputAction.search,
onSubmitted: (String _) { onSubmitted: (String _) {
widget.delegate.showResults(context); widget.delegate.showResults(context);
}, },

2
packages/flutter/lib/src/material/text_field.dart
View File

@ -17,7 +17,7 @@ import 'material.dart';
import 'text_selection.dart'; import 'text_selection.dart';
import 'theme.dart'; import 'theme.dart';
export 'package:flutter/services.dart' show TextInputType; export 'package:flutter/services.dart' show TextInputType, TextInputAction;
/// A material design text field. /// A material design text field.
/// ///

14
packages/flutter/test/material/search_test.dart
View File

@ -463,6 +463,20 @@ void main() {
expect(nestedSearchResults, <String>[null]); expect(nestedSearchResults, <String>[null]);
expect(selectedResults, <String>['Result Foo']); expect(selectedResults, <String>['Result Foo']);
}); });
testWidgets('keyboard show search button', (WidgetTester tester) async {
final _TestSearchDelegate delegate = new _TestSearchDelegate();
await tester.pumpWidget(new TestHomePage(
delegate: delegate,
));
await tester.tap(find.byTooltip('Search'));
await tester.pumpAndSettle();
await tester.showKeyboard(find.byType(TextField));
expect(tester.testTextInput.setClientArgs['inputAction'], TextInputAction.search.toString());
});
} }
class TestHomePage extends StatelessWidget { class TestHomePage extends StatelessWidget {