firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update docs after #165258 (#165716)

Browse Source 
Follow up from #165258 
Removes references to the deleted Infra-Ticket-Queue.md, and mentions of
the Infra Ticket Queue Github project.
Not sure if we should keep the issue template?

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Kate Lovett 2025-03-25 16:09:57 -05:00 committed by GitHub
parent 7692c1143e
commit 6832ac7a95
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/ISSUE_TEMPLATE/6_infrastructure.yml vendored
View File

@ -1,3 +1,4 @@
# TODO(matan): Update to reflect the new infra world, https://github.com/flutter/flutter/issues/165814
name: The CI infrastructure used by Flutter has a problem
description: |
As a contributor, you want to file an issue about the build/test/release
@ -23,11 +24,10 @@ body:
description: |
Is this a bug, feature request or Infra Task?
If you have a bug and you believe the issue is a blocker please add the P0 label and
set the project to 'Infra Ticket Queue.'
If you have a bug and you believe the issue is a blocker please add the `P0` label.
If this is a devicelab feature such as a package update or a device is down please
add the 'device-lab' label to the created issue and set the project to 'Infra Ticket Queue.'
add the `infra: device lab` label to the created issue.
options:
- bug
- feature request

8
dev/bots/README.md
View File

@ -5,9 +5,8 @@ This directory exists to support building Flutter on our build infrastructure.
Flutter build results are available at: <https://flutter-dashboard.appspot.com>.
Flutter infra requires special permissions to retrigger builds on the
[build dashboard](https://flutter-dashboard.appspot.com/#/build). File an
[infra ticket](../../docs/infra/Infra-Ticket-Queue.md) to
request permission.
[build dashboard](https://flutter-dashboard.appspot.com/#/build). File a `team-infra`
issue to request permission.
The [LUCI](https://chromium.googlesource.com/infra/luci/luci-py/+/refs/heads/main/README.md)-based
bots run the [`test.dart`](test.dart) script for each PR and submission. This
@ -26,8 +25,7 @@ The build dashboard includes post-commit testing run on physical devices. See
A [set of infra scripts](https://flutter.googlesource.com/recipes/)
run on Windows, Linux, and Mac machines. The configuration for how many
machines and what kind are managed internally by Google. File an
[infra ticket](../../docs/infra/Infra-Ticket-Queue.md)
machines and what kind are managed internally by Google. File a `team-infra` issue
to request new machine types to be added. Both of these technologies are highly
specific to the [LUCI](https://github.com/luci) project, which is the successor
to Chromium's infra and the foundation to Flutter's infrastructure.

4
dev/devicelab/README.md
View File

@ -240,8 +240,8 @@ target for each operating system.
## Adding tests to presubmit
Flutter's DeviceLab has a limited capacity in presubmit. File an infra ticket
to investigate feasibility of adding a test to presubmit.
Flutter's DeviceLab has a limited capacity in presubmit. File a `team-infra`
issue to investigate feasibility of adding a test to presubmit.
## Migrating to build and test model

4
docs/infra/Flutter-Framework-Gardener-Rotation.md
View File

@ -137,7 +137,7 @@ See the [golden test build breakage] guide.
1. Open a [new infra issue].
1. Add a descriptive title. A message like "Add a LUCI builder for linux web engine" or "Debug gallery startup" is much more helpful than "quick request" or "test doesn't work?".
1. Clearly describe the issue or request in the description field. For example, if a ticket is requesting running several commands on the bots, the ticket should explain why, what commands are needed, on which bots and how to verify the results.
1. Add the `team: infra` label and a priority label:
1. Add the `team-infra` label and a priority label:
* `P0` (immediate): Such as a build break or regression.
* Fix as soon as possible, before any other work.
* Should be very rare, and only used when critical work is blocked without a workaround.
@ -147,8 +147,6 @@ See the [golden test build breakage] guide.
* Degraded service (Build bots work but are slow to start).
* Time-sensitive requests.
* Should be relatively rare.
* Anything below `P1` is not suitable for the infra ticket queue and will be treated as a normal infra bug.
1. Add the project "Infra Ticket Queue".
1. Click the create button. No need to set an assignee; infra oncall will handle all new tickets.
## Communication channels (public)

1
docs/infra/README.md
View File

@ -11,6 +11,5 @@ This is an index of team-facing documentation for topics relating to Engineering
- [Flutter's Build Infrastructure](../../dev/bots/README.md)
- [Flutter's repository architecture](../about/Flutter's-repository-architecture.md)
- [GitHub Action Workflows](GitHub-Action-Workflows.md)
- [Infra Ticket Queue](Infra-Ticket-Queue.md)
- [Labeling PRs](../contributing/Labeling-PRs.md)
- [New Android Version](../platforms/android/New-Android-version.md)

1
docs/infra/Understanding-a-LUCI-build-failure.md
View File

@ -25,7 +25,6 @@ An example build: [Linux color_filter_and_fade_perf__e2e_summary](https://ci.chr
1. Check if the infra failure has happened on earlier builds by clicking (i)
2. Check if issue already exists in the [infra bug pool](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22team%3A+infra%22)
3. If not, file [an infra bug](https://github.com/flutter/flutter/issues/new?template=6_infrastructure.yml)
4. If this is a blocking failure, please add Projects [`Infra Ticket Queue`](./Infra-Ticket-Queue.md). The infra gardener will scan through the queue frequently.
5. If you want to get an immediate help, please ask in the discord `hackers-infra` channel
6. If this is an infra flake, and a retry is needed
* For pre-submit test, click `Re-run` in the [check run page](https://github.com/flutter/flutter/pull/83894/checks?check_run_id=2738146673). ![The presubmit rerun interface](https://github.com/flutter/assets-for-api-docs/blob/main/assets/wiki/luci_pre_submit_rerun.png)

2
docs/triage/README.md
View File

@ -336,7 +336,7 @@ During these meetings, we go through the following lists:
* [P0](https://github.com/flutter/flutter/issues?q=is%3Aopen+label%3AP0+sort%3Aupdated-asc): all bugs should be assigned, and progress should be happening actively. There should be an update within the last week. If no progress is happening and owner cannot work on it immediately (e.g. they're on vacation, they're busy with their day job, family reasons, etc), find a new owner.
* [Bugs flagged for additional triage](https://github.com/flutter/flutter/issues?q=is%3Aopen+label%3A%22will+need+additional+triage%22+sort%3Aupdated-asc+no%3Aassignee): figure out what should be done with the bug, then remove the `will need additional triage` label.
* [flutter-pub-roller-bot](https://github.com/flutter/flutter/pulls/flutter-pub-roller-bot): check that the pub auto roller is chugging along. If it has gotten trivially stuck, such as having a merge conflict, close the PR so that it can open a new one. If it is non-trivially stuck, file an issue for the infra ticket queue: https://github.com/flutter/flutter/blob/main/docs/infra/Infra-Ticket-Queue.md.
* [flutter-pub-roller-bot](https://github.com/flutter/flutter/pulls/flutter-pub-roller-bot): check that the pub auto roller is chugging along. If it has gotten trivially stuck, such as having a merge conflict, close the PR so that it can open a new one. If it is non-trivially stuck, file an issue for `team-infra`.
* [The stale PRs](https://github.com/pulls?q=is%3Aopen+is%3Apr+archived%3Afalse+user%3Aflutter+-repo%3Aflutter%2Fwebsite-cms+sort%3Aupdated-asc+): examine the 25 least-recently updated PRs, if the least recently updated one was updated more than 2 months ago.
## Self test issue