firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix shrine (#89698)

Browse Source
This commit is contained in:
Kate Lovett 2021-09-17 20:13:06 -05:00 committed by GitHub
parent e86394701d
commit 68836deabf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dev/integration_tests/flutter_gallery/lib/demo/shrine/app.dart
View File

@ -37,6 +37,11 @@ class _ShrineAppState extends State<ShrineApp> with SingleTickerProviderStateMix
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
return MaterialApp( return MaterialApp(
// The automatically applied scrollbars on desktop can cause a crash for
// demos where many scrollables are all attached to the same
// PrimaryScrollController. The gallery needs to be migrated before
// enabling this. https://github.com/flutter/gallery/issues/523
scrollBehavior: const MaterialScrollBehavior().copyWith(scrollbars: false),
title: 'Shrine', title: 'Shrine',
home: HomePage( home: HomePage(
backdrop: Backdrop( backdrop: Backdrop(

6
dev/integration_tests/flutter_gallery/test/smoke_test.dart
View File

@ -176,7 +176,11 @@ Future<void> smokeGallery(WidgetTester tester) async {
} }
void main() { void main() {
testWidgets('Flutter Gallery app smoke test', smokeGallery); testWidgets(
'Flutter Gallery app smoke test',
smokeGallery,
variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.android, TargetPlatform.macOS }),
);
testWidgets('Flutter Gallery app smoke test with semantics', (WidgetTester tester) async { testWidgets('Flutter Gallery app smoke test with semantics', (WidgetTester tester) async {
RendererBinding.instance!.setSemanticsEnabled(true); RendererBinding.instance!.setSemanticsEnabled(true);