From 68e346e41c6fc2a345995b80a0942d08f0150462 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 20 Dec 2023 14:14:32 -0800 Subject: [PATCH] Remove outdated ignores from tool (#140467) These were not ignoring anything (anymore). --- packages/flutter_test/lib/src/matchers.dart | 2 - packages/flutter_test/lib/src/window.dart | 1 - .../flutter_test/test/widget_tester_test.dart | 2 +- .../lib/src/isolated/devfs_web.dart | 1 - .../lib/src/isolated/resident_web_runner.dart | 1 - .../lib/src/resident_runner.dart | 1 - .../commands.shard/hermetic/attach_test.dart | 6 --- .../hermetic/custom_devices_test.dart | 12 ++--- .../commands.shard/hermetic/daemon_test.dart | 3 -- .../commands.shard/hermetic/doctor_test.dart | 3 -- .../commands.shard/hermetic/drive_test.dart | 8 ---- .../commands.shard/hermetic/install_test.dart | 6 --- .../hermetic/proxied_devices_test.dart | 3 -- .../commands.shard/hermetic/run_test.dart | 6 --- .../android/adb_log_reader_test.dart | 3 -- .../test/general.shard/cold_test.dart | 3 -- .../drive/drive_service_test.dart | 3 -- .../drive/web_driver_service_test.dart | 3 -- .../fuchsia/fuchsia_device_test.dart | 3 -- .../test/general.shard/hot_test.dart | 3 -- .../general.shard/mdns_discovery_test.dart | 3 -- .../test/general.shard/project_test.dart | 1 - .../resident_devtools_handler_test.dart | 3 -- .../general.shard/resident_runner_test.dart | 3 -- .../resident_web_runner_cold_test.dart | 3 -- .../resident_web_runner_test.dart | 10 ---- .../runner/target_devices_test.dart | 6 --- .../general.shard/terminal_handler_test.dart | 3 -- .../test/general.shard/vmservice_test.dart | 3 -- .../general.shard/web/devfs_web_test.dart | 46 +++++++++---------- 30 files changed, 30 insertions(+), 124 deletions(-) diff --git a/packages/flutter_test/lib/src/matchers.dart b/packages/flutter_test/lib/src/matchers.dart index 59308ccd28..f5db0a6b3f 100644 --- a/packages/flutter_test/lib/src/matchers.dart +++ b/packages/flutter_test/lib/src/matchers.dart @@ -1481,8 +1481,6 @@ double _matrix3Distance(Matrix3 a, Matrix3 b) { } double _sizeDistance(Size a, Size b) { - // TODO(a14n): remove ignore when lint is updated, https://github.com/dart-lang/linter/issues/1843 - // ignore: unnecessary_parenthesis final Offset delta = (b - a) as Offset; return delta.distance; } diff --git a/packages/flutter_test/lib/src/window.dart b/packages/flutter_test/lib/src/window.dart index 918949adc1..5a38fe531a 100644 --- a/packages/flutter_test/lib/src/window.dart +++ b/packages/flutter_test/lib/src/window.dart @@ -13,7 +13,6 @@ import 'package:flutter/foundation.dart'; /// features are enabled, consider the [FakeAccessibilityFeatures.allOn] /// constant. @immutable -// ignore: avoid_implementing_value_types class FakeAccessibilityFeatures implements AccessibilityFeatures { /// Creates a test instance of [AccessibilityFeatures]. /// diff --git a/packages/flutter_test/test/widget_tester_test.dart b/packages/flutter_test/test/widget_tester_test.dart index e8944bee55..846994a053 100644 --- a/packages/flutter_test/test/widget_tester_test.dart +++ b/packages/flutter_test/test/widget_tester_test.dart @@ -14,7 +14,7 @@ import 'package:flutter/scheduler.dart'; import 'package:flutter/services.dart'; import 'package:flutter_test/flutter_test.dart'; import 'package:matcher/expect.dart' as matcher; -import 'package:matcher/src/expect/async_matcher.dart'; // ignore: implementation_imports +import 'package:matcher/src/expect/async_matcher.dart'; void main() { group('expectLater', () { diff --git a/packages/flutter_tools/lib/src/isolated/devfs_web.dart b/packages/flutter_tools/lib/src/isolated/devfs_web.dart index 2f083b6d1a..7798b3ab3b 100644 --- a/packages/flutter_tools/lib/src/isolated/devfs_web.dart +++ b/packages/flutter_tools/lib/src/isolated/devfs_web.dart @@ -6,7 +6,6 @@ import 'dart:async'; import 'dart:typed_data'; import 'package:dwds/data/build_result.dart'; -// ignore: import_of_legacy_library_into_null_safe import 'package:dwds/dwds.dart'; import 'package:logging/logging.dart' as logging; import 'package:meta/meta.dart'; diff --git a/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart b/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart index b3c0682db7..545df737bd 100644 --- a/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart +++ b/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart @@ -4,7 +4,6 @@ import 'dart:async'; -// ignore: import_of_legacy_library_into_null_safe import 'package:dwds/dwds.dart'; import 'package:package_config/package_config.dart'; import 'package:unified_analytics/unified_analytics.dart'; diff --git a/packages/flutter_tools/lib/src/resident_runner.dart b/packages/flutter_tools/lib/src/resident_runner.dart index 978864cb56..e22d2ed231 100644 --- a/packages/flutter_tools/lib/src/resident_runner.dart +++ b/packages/flutter_tools/lib/src/resident_runner.dart @@ -229,7 +229,6 @@ class FlutterDevice { FlutterVmService? vmService; DevFS? devFS; ApplicationPackage? package; - // ignore: cancel_subscriptions StreamSubscription? _loggingSubscription; bool? _isListeningForVmServiceUri; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart index 14628ca916..ceda608b3e 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/attach_test.dart @@ -1399,9 +1399,6 @@ class FakeDartDevelopmentService extends Fake implements DartDevelopmentService Uri get uri => Uri.parse('http://localhost:8181'); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeAndroidDevice extends Fake implements AndroidDevice { FakeAndroidDevice({required this.id}); @@ -1473,9 +1470,6 @@ class FakeAndroidDevice extends Fake implements AndroidDevice { bool get ephemeral => true; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIOSDevice extends Fake implements IOSDevice { FakeIOSDevice({ DevicePortForwarder? portForwarder, diff --git a/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart index 556a77fc70..738b4b66e3 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart @@ -550,7 +550,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: const [ 'scp', '-r', @@ -640,7 +640,7 @@ void main() { '-w', '1', '192.168.178.1', ], - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: const [ 'scp', '-r', @@ -730,7 +730,7 @@ void main() { '-w', '1', '::1', ], - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: const [ 'scp', '-r', @@ -824,7 +824,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: [ 'scp', '-r', @@ -904,7 +904,7 @@ void main() { '-w', '1', 'testhostname', ], - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: const [ 'scp', '-r', @@ -1229,7 +1229,7 @@ void main() { 'testhostname', ], pingSuccessRegex: RegExp(r'[<=]\d+ms'), - postBuildCommand: null, // ignore: avoid_redundant_argument_values + postBuildCommand: null, installCommand: const [ 'scp', '-r', diff --git a/packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart index 63f8f1fdea..1ddc2d4f5a 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/daemon_test.dart @@ -951,9 +951,6 @@ class FakeIOSWorkflow extends Fake implements IOSWorkflow { final bool canListDevices; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeAndroidDevice extends Fake implements AndroidDevice { @override final String id = 'device'; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart index 873a8ad522..c0a2d2ad64 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart @@ -1420,9 +1420,6 @@ class FakeDeviceManager extends Fake implements DeviceManager { Future> getDeviceDiagnostics() async => diagnostics; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override String get name => 'name'; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart index ec7194f240..a8d11116ed 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/drive_test.dart @@ -539,8 +539,6 @@ void main() { }); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. class ThrowingScreenshotDevice extends ScreenshotDevice { @override Future startApp( @@ -558,9 +556,6 @@ class ThrowingScreenshotDevice extends ScreenshotDevice { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class ScreenshotDevice extends Fake implements Device { final List screenshots = []; @@ -699,9 +694,6 @@ class FakeProcessSignal extends Fake implements io.ProcessSignal { Stream watch() => controller.stream; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIosDevice extends Fake implements IOSDevice { @override DeviceConnectionInterface connectionInterface = DeviceConnectionInterface.attached; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/install_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/install_test.dart index b2c549d9a4..c758defc53 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/install_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/install_test.dart @@ -139,9 +139,6 @@ class FakeApplicationPackageFactory extends Fake implements ApplicationPackageFa class FakeIOSApp extends Fake implements IOSApp { } class FakeAndroidApk extends Fake implements AndroidApk { } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIOSDevice extends Fake implements IOSDevice { @override Future get targetPlatform async => TargetPlatform.ios; @@ -162,9 +159,6 @@ class FakeIOSDevice extends Fake implements IOSDevice { String get name => 'iOS'; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeAndroidDevice extends Fake implements AndroidDevice { @override Future get targetPlatform async => TargetPlatform.android_arm; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/proxied_devices_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/proxied_devices_test.dart index 9dbfa3ce9a..29d2bafdf3 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/proxied_devices_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/proxied_devices_test.dart @@ -246,9 +246,6 @@ class FakeDaemonStreams implements DaemonStreams { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeAndroidDevice extends Fake implements AndroidDevice { @override final String id = 'device'; diff --git a/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart index 6aef5d2ebb..2307c1e350 100644 --- a/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart +++ b/packages/flutter_tools/test/commands.shard/hermetic/run_test.dart @@ -1301,9 +1301,6 @@ class FakeAndroidSdk extends Fake implements AndroidSdk { String get adbPath => 'adb'; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { FakeDevice({ bool isLocalEmulator = false, @@ -1439,9 +1436,6 @@ class FakeDevice extends Fake implements Device { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIOSDevice extends Fake implements IOSDevice { FakeIOSDevice({ this.connectionInterface = DeviceConnectionInterface.attached, diff --git a/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart b/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart index 5df9d4b37a..543aff1c7c 100644 --- a/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart +++ b/packages/flutter_tools/test/general.shard/android/adb_log_reader_test.dart @@ -225,9 +225,6 @@ AndroidDevice createFakeDevice(int? sdkLevel) { ); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeAndroidDevice extends Fake implements AndroidDevice { FakeAndroidDevice(this._apiVersion, this._lastLogcatTimestamp); diff --git a/packages/flutter_tools/test/general.shard/cold_test.dart b/packages/flutter_tools/test/general.shard/cold_test.dart index 8c7fdd1b79..7ebb61a2e4 100644 --- a/packages/flutter_tools/test/general.shard/cold_test.dart +++ b/packages/flutter_tools/test/general.shard/cold_test.dart @@ -168,9 +168,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice { Future initLogReader() async { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override bool isSupported() => true; diff --git a/packages/flutter_tools/test/general.shard/drive/drive_service_test.dart b/packages/flutter_tools/test/general.shard/drive/drive_service_test.dart index 6a6b527910..f0bdc98b31 100644 --- a/packages/flutter_tools/test/general.shard/drive/drive_service_test.dart +++ b/packages/flutter_tools/test/general.shard/drive/drive_service_test.dart @@ -476,9 +476,6 @@ class FakeApplicationPackageFactory extends Fake implements ApplicationPackageFa class FakeApplicationPackage extends Fake implements ApplicationPackage { } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { FakeDevice(this.result, {this.supportsFlutterExit = true}); diff --git a/packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart b/packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart index 2c73630d7b..a9c3846905 100644 --- a/packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart +++ b/packages/flutter_tools/test/general.shard/drive/web_driver_service_test.dart @@ -384,9 +384,6 @@ WebDriverService setUpDriverService() { ); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override final PlatformType platformType = PlatformType.web; diff --git a/packages/flutter_tools/test/general.shard/fuchsia/fuchsia_device_test.dart b/packages/flutter_tools/test/general.shard/fuchsia/fuchsia_device_test.dart index c439a0787e..b68c2a4abe 100644 --- a/packages/flutter_tools/test/general.shard/fuchsia/fuchsia_device_test.dart +++ b/packages/flutter_tools/test/general.shard/fuchsia/fuchsia_device_test.dart @@ -945,9 +945,6 @@ class FuchsiaModulePackage extends ApplicationPackage { final String name; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class MockFuchsiaDevice extends Fake implements FuchsiaDevice { MockFuchsiaDevice(this.id, this.portForwarder, this._ipv6); diff --git a/packages/flutter_tools/test/general.shard/hot_test.dart b/packages/flutter_tools/test/general.shard/hot_test.dart index 661fb608f4..c357e144cd 100644 --- a/packages/flutter_tools/test/general.shard/hot_test.dart +++ b/packages/flutter_tools/test/general.shard/hot_test.dart @@ -786,9 +786,6 @@ class FakeDevFs extends Fake implements DevFS { Uri? baseUri; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { FakeDevice({ TargetPlatform targetPlatform = TargetPlatform.tester, diff --git a/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart b/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart index 2190b5fe62..79aa29a920 100644 --- a/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart +++ b/packages/flutter_tools/test/general.shard/mdns_discovery_test.dart @@ -1038,9 +1038,6 @@ class FakeMDnsClient extends Fake implements MDnsClient { void stop() {} } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIOSDevice extends Fake implements IOSDevice { FakeIOSDevice({this.name = 'iPhone'}); diff --git a/packages/flutter_tools/test/general.shard/project_test.dart b/packages/flutter_tools/test/general.shard/project_test.dart index ebbbd779c6..bea413c09a 100644 --- a/packages/flutter_tools/test/general.shard/project_test.dart +++ b/packages/flutter_tools/test/general.shard/project_test.dart @@ -1591,7 +1591,6 @@ void addGradleWrapperFile(Directory directory, String gradleVersion) { .childDirectory(gradle_utils.gradleWrapperDirectoryName) .childFile(gradle_utils.gradleWrapperPropertiesFilename) ..createSync(recursive: true) - // ignore: unnecessary_string_escapes ..writeAsStringSync(''' distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists diff --git a/packages/flutter_tools/test/general.shard/resident_devtools_handler_test.dart b/packages/flutter_tools/test/general.shard/resident_devtools_handler_test.dart index 56d933291e..0aab7fd610 100644 --- a/packages/flutter_tools/test/general.shard/resident_devtools_handler_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_devtools_handler_test.dart @@ -467,9 +467,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice { TargetPlatform targetPlatform = TargetPlatform.android_arm; } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override DartDevelopmentService get dds => FakeDartDevelopmentService(); diff --git a/packages/flutter_tools/test/general.shard/resident_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_runner_test.dart index a06cc1e53d..454701781b 100644 --- a/packages/flutter_tools/test/general.shard/resident_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_runner_test.dart @@ -2740,9 +2740,6 @@ class FakeProjectFileInvalidator extends Fake implements ProjectFileInvalidator } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { FakeDevice({ String sdkNameAndVersion = 'Android', diff --git a/packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart b/packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart index 4c467bb826..a777028be3 100644 --- a/packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_web_runner_cold_test.dart @@ -201,9 +201,6 @@ class FakeWebDevFS extends Fake implements WebDevFS { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeWebDevice extends Fake implements Device { @override String get name => 'web'; diff --git a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart index ca4fec8cf8..592d75b20c 100644 --- a/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart +++ b/packages/flutter_tools/test/general.shard/resident_web_runner_test.dart @@ -1417,14 +1417,8 @@ ResidentRunner setUpResidentRunner( ); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeWebServerDevice extends FakeDevice implements WebServerDevice {} -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override String name = 'FakeDevice'; @@ -1494,10 +1488,6 @@ class FakeAppConnection extends Fake implements AppConnection { ranMain = true; } } - -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeChromeDevice extends Fake implements ChromiumDevice {} class FakeWipDebugger extends Fake implements WipDebugger {} diff --git a/packages/flutter_tools/test/general.shard/runner/target_devices_test.dart b/packages/flutter_tools/test/general.shard/runner/target_devices_test.dart index 7befa7793c..35a3015fb0 100644 --- a/packages/flutter_tools/test/general.shard/runner/target_devices_test.dart +++ b/packages/flutter_tools/test/general.shard/runner/target_devices_test.dart @@ -2677,9 +2677,6 @@ class FakeXcdevice extends Fake implements XCDevice { class FakeIOSWorkflow extends Fake implements IOSWorkflow {} -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { FakeDevice({ String? deviceId, @@ -2776,9 +2773,6 @@ class FakeDevice extends Fake implements Device { getNameForTargetPlatform(await targetPlatform); } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeIOSDevice extends Fake implements IOSDevice { FakeIOSDevice({ String? deviceId, diff --git a/packages/flutter_tools/test/general.shard/terminal_handler_test.dart b/packages/flutter_tools/test/general.shard/terminal_handler_test.dart index 33f615c85a..87ab451d96 100644 --- a/packages/flutter_tools/test/general.shard/terminal_handler_test.dart +++ b/packages/flutter_tools/test/general.shard/terminal_handler_test.dart @@ -1322,9 +1322,6 @@ class FakeResidentDevtoolsHandler extends Fake implements ResidentDevtoolsHandle } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { @override bool isSupported() => true; diff --git a/packages/flutter_tools/test/general.shard/vmservice_test.dart b/packages/flutter_tools/test/general.shard/vmservice_test.dart index 2557b3a289..4b91dac99f 100644 --- a/packages/flutter_tools/test/general.shard/vmservice_test.dart +++ b/packages/flutter_tools/test/general.shard/vmservice_test.dart @@ -874,9 +874,6 @@ class MockVMService extends Fake implements vm_service.VmService { } } -// Unfortunately Device, despite not being immutable, has an `operator ==`. -// Until we fix that, we have to also ignore related lints here. -// ignore: avoid_implementing_value_types class FakeDevice extends Fake implements Device { } /// A [WebSocketConnector] that always throws an [io.SocketException]. diff --git a/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart b/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart index aa9dfdac95..7a9ce0476d 100644 --- a/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart +++ b/packages/flutter_tools/test/general.shard/web/devfs_web_test.dart @@ -71,9 +71,9 @@ void main() { releaseAssetServer = ReleaseAssetServer( globals.fs.file('main.dart').uri, fileSystem: globals.fs, - flutterRoot: null, // ignore: avoid_redundant_argument_values + flutterRoot: null, platform: FakePlatform(), - webBuildDirectory: null, // ignore: avoid_redundant_argument_values + webBuildDirectory: null, ); }, overrides: { Logger: () => logger, @@ -665,7 +665,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -681,9 +681,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.unsound, ); webDevFS.requireJS.createSync(recursive: true); @@ -782,7 +782,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -797,9 +797,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -960,7 +960,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -969,9 +969,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullAssertions: true, nativeNullAssertions: true, nullSafetyMode: NullSafetyMode.sound, @@ -998,7 +998,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -1016,9 +1016,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -1044,7 +1044,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -1062,9 +1062,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.sound, ); webDevFS.requireJS.createSync(recursive: true); @@ -1098,7 +1098,7 @@ void main() { tlsCertPath: dummyCertPath, tlsCertKeyPath: dummyCertKeyPath, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -1109,9 +1109,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.unsound, ); webDevFS.requireJS.createSync(recursive: true); @@ -1243,7 +1243,7 @@ void main() { tlsCertPath: null, tlsCertKeyPath: null, packagesFilePath: '.packages', - urlTunneller: null, // ignore: avoid_redundant_argument_values + urlTunneller: null, useSseForDebugProxy: true, useSseForDebugBackend: true, useSseForInjectedClient: true, @@ -1254,9 +1254,9 @@ void main() { enableDds: false, entrypoint: Uri.base, testMode: true, - expressionCompiler: null, // ignore: avoid_redundant_argument_values + expressionCompiler: null, extraHeaders: const {}, - chromiumLauncher: null, // ignore: avoid_redundant_argument_values + chromiumLauncher: null, nullSafetyMode: NullSafetyMode.unsound, ); webDevFS.requireJS.createSync(recursive: true);