firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1182 from Hixie/ancestor

Browse Source 
Clarify why we don't assert that ancestor != null.
This commit is contained in:
Ian Hickson 2015-09-16 09:06:14 -07:00
commit 6b4352bb14
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/widgets/framework.dart
View File

@ -1176,8 +1176,13 @@ abstract class RenderObjectWrapper extends Widget {
assert(() { assert(() {
if (current is ParentDataNode) { if (current is ParentDataNode) {
Widget ancestor = current.parent; Widget ancestor = current.parent;
while (ancestor != null && ancestor is Component) while (ancestor is Component)
ancestor = ancestor.parent; ancestor = ancestor.parent;
// ancestor might be null in two cases:
// - asking for the ancestor of a Widget that has no non-Component
// ancestors between itself and its AbstractWidgetRoot ancestor
// - if the node is just being synced to get its intrinsic
// dimensions, as e.g. MixedViewport does.
if (ancestor != null) if (ancestor != null)
current.debugValidateAncestor(ancestor); current.debugValidateAncestor(ancestor);
} }