[canvaskit] Fix debug build for CanvasKit (#162198)

Fixes the debug build for CanvasKit.

NOTE: We need to build the debug WASM build with `-O1` because building
with `-O0` causes Emscripten to produce a binary that is rejected by
Chrome for having functions with too many local variables. Building with
`-O1` optimizes those locals out.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Harry Terkelsen 2025-01-27 09:56:33 -08:00 committed by GitHub
parent a2c56f3d75
commit 6b8ead49f3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 4 deletions

View File

@ -933,6 +933,14 @@ config("no_optimize") {
cflags += [ "-fomit-frame-pointer" ]
}
ldflags = common_optimize_on_ldflags
} else if (is_wasm) {
# On WASM we don't want to fully deoptimize the debug build because the
# compiled binary will have some functions with too many local variables
# and Chrome will reject it.
cflags = [
"-O1",
]
ldflags = common_optimize_on_ldflags
} else {
cflags = [ "-O0" ]
}

View File

@ -62,7 +62,7 @@ canvaskit_wasm_lib("canvaskit") {
ldflags = []
if (is_debug) {
ldflags += [
"-O0",
"-O1",
"-sASSERTIONS=1",
"-sGL_ASSERTIONS=1",
"-g3",
@ -110,14 +110,14 @@ canvaskit_wasm_lib("canvaskit") {
"--bind",
"--no-entry",
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/util.js"),
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/preamble.js"),
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/color.js"),
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/memory.js"),
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/util.js"),
"--pre-js",
rebase_path("$_skia_root/modules/canvaskit/interface.js"),
]
@ -164,7 +164,7 @@ canvaskit_wasm_lib("canvaskit") {
"-sEXPORT_NAME=CanvasKitInit",
"-sEXPORTED_FUNCTIONS=[_malloc,_free]",
"-sEXPORTED_RUNTIME_METHODS=HEAP8,HEAPU8,HEAP16,HEAPU16,HEAP32,HEAPF32,HEAPU32,HEAPF64",
"-sINCOMING_MODULE_JS_API=onRuntimeInitialized",
"-sINCOMING_MODULE_JS_API=[instantiateWasm,onRuntimeInitialized,noExitRuntime]",
"-sFORCE_FILESYSTEM=0",
"-sFILESYSTEM=0",
"-sMODULARIZE",