firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

labeledTapTargetGuideline should passe if textfield does not have label (#116221)

Browse Source
This commit is contained in:
chunhtai 2022-11-29 16:10:07 -08:00 committed by GitHub
parent 9532b91c74
commit 6b98f2ca44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_test/lib/src/accessibility.dart
View File

@ -219,7 +219,8 @@ class LabeledTapTargetGuideline extends AccessibilityGuideline {
}); });
if (node.isMergedIntoParent || if (node.isMergedIntoParent ||
node.isInvisible || node.isInvisible ||
node.hasFlag(ui.SemanticsFlag.isHidden)) { node.hasFlag(ui.SemanticsFlag.isHidden) ||
node.hasFlag(ui.SemanticsFlag.isTextField)) {
return result; return result;
} }
final SemanticsData data = node.getSemanticsData(); final SemanticsData data = node.getSemanticsData();

8
packages/flutter_test/test/accessibility_test.dart
View File

@ -874,6 +874,14 @@ void main() {
expect(result.passed, true); expect(result.passed, true);
handle.dispose(); handle.dispose();
}); });
testWidgets('Passes if text field does not have label', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics();
await tester.pumpWidget(_boilerplate(const TextField()));
final Evaluation result = await labeledTapTargetGuideline.evaluate(tester);
expect(result.passed, true);
handle.dispose();
});
}); });
testWidgets('regression test for material widget', testWidgets('regression test for material widget',