firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] fix instructions to disable CLI animations (#139094)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/139011
This commit is contained in:
Christopher Fujino 2023-11-27 14:00:50 -08:00 committed by GitHub
parent 6035c5ccba
commit 6bf3ccd47d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/features.dart
View File

@ -156,12 +156,14 @@ const Feature flutterWebWasm = Feature(
), ),
); );
const String kCliAnimationsFeatureName = 'cli-animations';
/// The [Feature] for CLI animations. /// The [Feature] for CLI animations.
/// ///
/// The TERM environment variable set to "dumb" turns this off. /// The TERM environment variable set to "dumb" turns this off.
const Feature cliAnimation = Feature.fullyEnabled( const Feature cliAnimation = Feature.fullyEnabled(
name: 'animations in the command line interface', name: 'animations in the command line interface',
configSetting: 'cli-animations', configSetting: kCliAnimationsFeatureName,
); );
/// Enable native assets compilation and bundling. /// Enable native assets compilation and bundling.

3
packages/flutter_tools/lib/src/reporting/first_run.dart
View File

@ -36,7 +36,8 @@ const String _kFlutterFirstRunMessage = '''
║ See Google's privacy policy: ║ ║ See Google's privacy policy: ║
║ https://policies.google.com/privacy ║ ║ https://policies.google.com/privacy ║
║ ║ ║ ║
║ To disable animations in this tool, use 'flutter config --no-animations'. ║ ║ To disable animations in this tool, use ║
║ 'flutter config --no-cli-animations'. ║
╚════════════════════════════════════════════════════════════════════════════╝ ╚════════════════════════════════════════════════════════════════════════════╝
'''; ''';

7
packages/flutter_tools/test/general.shard/reporting/first_run_test.dart
View File

@ -4,6 +4,7 @@
import 'package:file/memory.dart'; import 'package:file/memory.dart';
import 'package:flutter_tools/src/base/logger.dart'; import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/features.dart';
import 'package:flutter_tools/src/persistent_tool_state.dart'; import 'package:flutter_tools/src/persistent_tool_state.dart';
import 'package:flutter_tools/src/reporting/first_run.dart'; import 'package:flutter_tools/src/reporting/first_run.dart';
@ -16,6 +17,12 @@ void main() {
expect(messenger.licenseTerms, contains('Welcome to Flutter')); expect(messenger.licenseTerms, contains('Welcome to Flutter'));
}); });
testWithoutContext('FirstRunMessenger informs user how to disable animations', () {
final FirstRunMessenger messenger = setUpFirstRunMessenger(redisplayWelcomeMessage: false);
expect(messenger.licenseTerms, contains('flutter config --no-$kCliAnimationsFeatureName'));
});
testWithoutContext('FirstRunMessenger requires redisplay if it has never been run before', () { testWithoutContext('FirstRunMessenger requires redisplay if it has never been run before', () {
final FirstRunMessenger messenger = setUpFirstRunMessenger(); final FirstRunMessenger messenger = setUpFirstRunMessenger();