firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate extraneous bool in DatePicker haptic feedback (#8337)

Browse Source
This commit is contained in:
Chris Bracken 2017-02-22 12:51:06 -08:00 committed by GitHub
parent c8f8d0014a
commit 6d135e4520
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
packages/flutter/lib/src/material/date_picker.dart
View File

@ -591,8 +591,6 @@ class _DatePickerDialog extends StatefulWidget {
} }
class _DatePickerDialogState extends State<_DatePickerDialog> { class _DatePickerDialogState extends State<_DatePickerDialog> {
bool _vibrate = false;
@override @override
void initState() { void initState() {
super.initState(); super.initState();
@ -603,17 +601,26 @@ class _DatePickerDialogState extends State<_DatePickerDialog> {
_DatePickerMode _mode = _DatePickerMode.day; _DatePickerMode _mode = _DatePickerMode.day;
GlobalKey _pickerKey = new GlobalKey(); GlobalKey _pickerKey = new GlobalKey();
void _vibrate() {
switch (Theme.of(context).platform) {
case TargetPlatform.android:
case TargetPlatform.fuchsia:
HapticFeedback.vibrate();
break;
case TargetPlatform.iOS:
break;
}
}
void _handleModeChanged(_DatePickerMode mode) { void _handleModeChanged(_DatePickerMode mode) {
if (_vibrate) _vibrate();
HapticFeedback.vibrate();
setState(() { setState(() {
_mode = mode; _mode = mode;
}); });
} }
void _handleYearChanged(DateTime value) { void _handleYearChanged(DateTime value) {
if (_vibrate) _vibrate();
HapticFeedback.vibrate();
setState(() { setState(() {
_mode = _DatePickerMode.day; _mode = _DatePickerMode.day;
_selectedDate = value; _selectedDate = value;
@ -621,8 +628,7 @@ class _DatePickerDialogState extends State<_DatePickerDialog> {
} }
void _handleDayChanged(DateTime value) { void _handleDayChanged(DateTime value) {
if (_vibrate) _vibrate();
HapticFeedback.vibrate();
setState(() { setState(() {
_selectedDate = value; _selectedDate = value;
}); });
@ -662,15 +668,6 @@ class _DatePickerDialogState extends State<_DatePickerDialog> {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
switch (Theme.of(context).platform) {
case TargetPlatform.android:
case TargetPlatform.fuchsia:
_vibrate = true;
break;
case TargetPlatform.iOS:
_vibrate = false;
break;
}
Widget picker = new Flexible( Widget picker = new Flexible(
child: new SizedBox( child: new SizedBox(
height: _kMaxDayPickerHeight, height: _kMaxDayPickerHeight,