Remove --disable-dart-dev across flutter/flutter. (#154280)

As per the Dart CLI team and @bkonyi, this is no longer providing value and we shouldn't cargo-cult it.

Work towards https://github.com/flutter/flutter/issues/154268.

bin/flutter.bat

@@ -52,4 +52,4 @@ REM
 REM Do not use the CALL command in the next line to execute Dart. CALL causes
 REM Windows to re-read the line from disk after the CALL command has finished
 REM regardless of the ampersand chain.
-"%dart%" --disable-dart-dev --packages="%flutter_tools_dir%\.dart_tool\package_config.json" %FLUTTER_TOOL_ARGS% "%snapshot_path%" %* & "%exit_with_errorlevel%"
+"%dart%" --packages="%flutter_tools_dir%\.dart_tool\package_config.json" %FLUTTER_TOOL_ARGS% "%snapshot_path%" %* & "%exit_with_errorlevel%"

bin/internal/shared.sh

@@ -168,7 +168,7 @@ function upgrade_flutter () (
     fi
 
     # Compile...
-    "$DART" --verbosity=error --disable-dart-dev $FLUTTER_TOOL_ARGS --snapshot="$SNAPSHOT_PATH" --snapshot-kind="app-jit" --packages="$FLUTTER_TOOLS_DIR/.dart_tool/package_config.json" --no-enable-mirrors "$SCRIPT_PATH" > /dev/null
+    "$DART" --verbosity=error $FLUTTER_TOOL_ARGS --snapshot="$SNAPSHOT_PATH" --snapshot-kind="app-jit" --packages="$FLUTTER_TOOLS_DIR/.dart_tool/package_config.json" --no-enable-mirrors "$SCRIPT_PATH" > /dev/null
     echo "$compilekey" > "$STAMP_PATH"
 
     # Delete any temporary snapshot path.
@@ -262,7 +262,7 @@ function shared::execute() {
     flutter*)
       # FLUTTER_TOOL_ARGS aren't quoted below, because it is meant to be
       # considered as separate space-separated args.
-      exec "$DART" --disable-dart-dev --packages="$FLUTTER_TOOLS_DIR/.dart_tool/package_config.json" $FLUTTER_TOOL_ARGS "$SNAPSHOT_PATH" "$@"
+      exec "$DART" --packages="$FLUTTER_TOOLS_DIR/.dart_tool/package_config.json" $FLUTTER_TOOL_ARGS "$SNAPSHOT_PATH" "$@"
       ;;
     dart*)
       exec "$DART" "$@"

dev/bots/docs.sh

@@ -132,7 +132,7 @@ function generate_docs() {
 
     # Make sure that create_api_docs.dart has all the dependencies it needs.
     (cd "$FLUTTER_ROOT/dev/tools" && "$FLUTTER" pub get)
-    (cd "$FLUTTER_ROOT" && "$DART" --disable-dart-dev --enable-asserts "$FLUTTER_ROOT/dev/tools/create_api_docs.dart" --output-dir="$DOC_DIR")
+    (cd "$FLUTTER_ROOT" && "$DART" --enable-asserts "$FLUTTER_ROOT/dev/tools/create_api_docs.dart" --output-dir="$DOC_DIR")
 }
 
 function main() {

dev/devicelab/lib/framework/runner.dart

@@ -187,6 +187,7 @@ Future<TaskResult> runTask(
   final Process runner = await startProcess(
     dartBin,
     <String>[
+      // TODO(matanlurey): This is load bearing; see https://github.com/flutter/flutter/issues/154268#issuecomment-2318996125.
       '--disable-dart-dev',
       '--enable-vm-service=0', // zero causes the system to choose a free port
       '--no-pause-isolates-on-exit',

dev/devicelab/lib/framework/utils.dart

@@ -642,7 +642,7 @@ String get dartBin =>
 String get pubBin =>
     path.join(flutterDirectory.path, 'bin', 'cache', 'dart-sdk', 'bin', 'pub');
 
-Future<int> dart(List<String> args) => exec(dartBin, <String>['--disable-dart-dev', ...args]);
+Future<int> dart(List<String> args) => exec(dartBin, args);
 
 /// Returns a future that completes with a path suitable for JAVA_HOME
 /// or with null, if Java cannot be found.

packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart

@@ -287,7 +287,6 @@ class IconTreeShaker {
   ) async {
     final List<String> cmd = <String>[
       dart.path,
-      '--disable-dart-dev',
       constFinder.path,
       '--kernel-file', appDill.path,
       '--class-library-uri', 'package:flutter/src/widgets/icon_data.dart',

packages/flutter_tools/lib/src/build_system/targets/web.dart

@@ -170,7 +170,6 @@ class Dart2JSTarget extends Dart2WebTarget {
     final String platformBinariesPath = artifacts.getHostArtifact(HostArtifact.webPlatformKernelFolder).path;
     final List<String> sharedCommandOptions = <String>[
       artifacts.getArtifactPath(Artifact.engineDartBinary, platform: TargetPlatform.web_javascript),
-      '--disable-dart-dev',
       artifacts.getArtifactPath(Artifact.dart2jsSnapshot, platform: TargetPlatform.web_javascript),
       '--platform-binaries=$platformBinariesPath',
       '--invoker=flutter_tool',

packages/flutter_tools/lib/src/compile.dart

@@ -280,7 +280,6 @@ class KernelCompiler {
       }
       commandToStartFrontendServer = <String>[
         engineDartPath,
-        '--disable-dart-dev',
         frontendServerStarterPath,
       ];
     } else {
@@ -290,7 +289,6 @@ class KernelCompiler {
       }
       commandToStartFrontendServer = <String>[
         engineDartAotRuntimePath,
-        '--disable-dart-dev',
         _artifacts.getArtifactPath(
           Artifact.frontendServerSnapshotForEngineDartSdk,
           platform: platform,
@@ -795,13 +793,11 @@ class DefaultResidentCompiler implements ResidentCompiler {
     if (frontendServerStarterPath != null && frontendServerStarterPath!.isNotEmpty) {
       commandToStartFrontendServer = <String>[
         artifacts.getArtifactPath(Artifact.engineDartBinary, platform: platform),
-        '--disable-dart-dev',
         frontendServerStarterPath!,
       ];
     } else {
       commandToStartFrontendServer = <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime, platform: platform),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(
           Artifact.frontendServerSnapshotForEngineDartSdk,
           platform: platform,

packages/flutter_tools/lib/src/dart/analysis.dart

@@ -62,7 +62,6 @@ class AnalysisServer {
     );
     final List<String> command = <String>[
       _fileSystem.path.join(sdkPath, 'bin', 'dart'),
-      '--disable-dart-dev',
       snapshot,
       '--disable-server-feature-completion',
       '--disable-server-feature-search',

packages/flutter_tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart

@@ -78,7 +78,6 @@ class FuchsiaKernelCompiler {
     }
     final List<String> command = <String>[
       engineDartBinaryPath,
-      '--disable-dart-dev',
       kernelCompiler,
       ...flags,
     ];

packages/flutter_tools/test/commands.shard/hermetic/analyze_continuously_test.dart

@@ -189,7 +189,6 @@ void main() {
         FakeCommand(
           command: const <String>[
             'Artifact.engineDartSdkPath/bin/dart',
-            '--disable-dart-dev',
             'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
             '--disable-server-feature-completion',
             '--disable-server-feature-search',
@@ -227,7 +226,6 @@ void main() {
         FakeCommand(
           command: const <String>[
             'Artifact.engineDartSdkPath/bin/dart',
-            '--disable-dart-dev',
             'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
             '--disable-server-feature-completion',
             '--disable-server-feature-search',
@@ -272,7 +270,6 @@ void main() {
         FakeCommand(
           command: const <String>[
             'Artifact.engineDartSdkPath/bin/dart',
-            '--disable-dart-dev',
             'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
             '--disable-server-feature-completion',
             '--disable-server-feature-search',
@@ -327,7 +324,6 @@ void main() {
           FakeCommand(
               command: const <String>[
                 'Artifact.engineDartSdkPath/bin/dart',
-                '--disable-dart-dev',
                 'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
                 '--disable-server-feature-completion',
                 '--disable-server-feature-search',

packages/flutter_tools/test/commands.shard/hermetic/analyze_test.dart

@@ -93,7 +93,6 @@ void main() {
             // artifact paths are from Artifacts.test() and stable
             command: <String>[
               'Artifact.engineDartSdkPath/bin/dart',
-              '--disable-dart-dev',
               'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
               '--disable-server-feature-completion',
               '--disable-server-feature-search',
@@ -131,7 +130,6 @@ void main() {
             // artifact paths are from Artifacts.test() and stable
             command: const <String>[
               'Artifact.engineDartSdkPath/bin/dart',
-              '--disable-dart-dev',
               'Artifact.engineDartSdkPath/bin/snapshots/analysis_server.dart.snapshot',
               '--disable-server-feature-completion',
               '--disable-server-feature-search',

packages/flutter_tools/test/general.shard/build_system/targets/common_test.dart

@@ -104,7 +104,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -144,7 +143,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -185,7 +183,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -227,7 +224,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartBinary),
-        '--disable-dart-dev',
         'path/to/frontend_server_starter.dart',
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -269,7 +265,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -314,7 +309,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -356,7 +350,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -410,7 +403,6 @@ native-assets:
     processManager.addCommands(<FakeCommand>[
       FakeCommand(command: <String>[
         artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-        '--disable-dart-dev',
         artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
         '--sdk-root',
         '$flutterPatchedSdkPath/',
@@ -458,7 +450,6 @@ native-assets:
           if (!empty)
             FakeCommand(command: <String>[
               artifacts.getArtifactPath(Artifact.engineDartAotRuntime),
-              '--disable-dart-dev',
               artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
               '--sdk-root',
               '$flutterPatchedSdkPath/',

packages/flutter_tools/test/general.shard/build_system/targets/icon_tree_shaker_test.dart

@@ -37,7 +37,6 @@ void main() {
 
   List<String> getConstFinderArgs(String appDillPath) => <String>[
     dartPath,
-    '--disable-dart-dev',
     constFinderPath,
     '--kernel-file', appDillPath,
     '--class-library-uri', 'package:flutter/src/widgets/icon_data.dart',

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart

@@ -23,7 +23,6 @@ import '../../../src/testbed.dart';
 
 const List<String> _kDart2jsLinuxArgs = <String>[
   'Artifact.engineDartBinary.TargetPlatform.web_javascript',
-  '--disable-dart-dev',
   'Artifact.dart2jsSnapshot.TargetPlatform.web_javascript',
   '--platform-binaries=HostArtifact.webPlatformKernelFolder',
   '--invoker=flutter_tool',

packages/flutter_tools/test/general.shard/compile_batch_test.dart

@@ -54,7 +54,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -100,7 +99,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -146,7 +144,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -192,7 +189,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -242,7 +238,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -292,7 +287,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -344,7 +338,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -394,7 +387,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',
@@ -454,7 +446,6 @@ void main() {
       processManager: FakeProcessManager.list(<FakeCommand>[
         FakeCommand(command: const <String>[
           'Artifact.engineDartAotRuntime',
-          '--disable-dart-dev',
           'Artifact.frontendServerSnapshotForEngineDartSdk',
           '--sdk-root',
           '/path/to/sdkroot/',

packages/flutter_tools/test/general.shard/compile_incremental_test.dart

@@ -31,7 +31,6 @@ void main() {
 
   const List<String> frontendServerCommand = <String>[
     'Artifact.engineDartAotRuntime',
-    '--disable-dart-dev',
     'Artifact.frontendServerSnapshotForEngineDartSdk',
     '--sdk-root',
     'sdkroot/',

packages/flutter_tools/test/general.shard/test/web_test_compiler_test.dart

@@ -38,7 +38,6 @@ void main() {
     final FakeProcessManager processManager = FakeProcessManager.list(<FakeCommand>[
       FakeCommand(command: <Pattern>[
         'Artifact.engineDartAotRuntime.TargetPlatform.web_javascript',
-        '--disable-dart-dev',
         'Artifact.frontendServerSnapshotForEngineDartSdk.TargetPlatform.web_javascript',
         '--sdk-root',
         'HostArtifact.flutterWebSdk/',