firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Switch flutter_tools from script to app-jit snapshot. (#27749)

Browse Source
This commit is contained in:
Jonah Williams 2019-03-15 19:33:24 -07:00 committed by GitHub
parent 23326db7a1
commit 72605d2406
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bin/flutter
View File

@ -121,7 +121,7 @@ function upgrade_flutter () {
retry_upgrade
"$DART" --snapshot="$SNAPSHOT_PATH" --packages="$FLUTTER_TOOLS_DIR/.packages" "$SCRIPT_PATH"
"$DART" --snapshot="$SNAPSHOT_PATH" --snapshot-kind=app-jit --packages="$FLUTTER_TOOLS_DIR/.packages" "$SCRIPT_PATH" training
echo "$revision" > "$STAMP_PATH"
fi
# The exit here is duplicitous since the function is run in a subshell,

2
bin/flutter.bat
View File

@ -152,7 +152,7 @@ GOTO :after_subroutine
POPD
"%dart%" --snapshot="%snapshot_path%" --packages="%flutter_tools_dir%\.packages" "%script_path%"
"%dart%" --snapshot="%snapshot_path%" --snapshot-kind=app-jit --packages="%flutter_tools_dir%\.packages" "%script_path%"
IF "%ERRORLEVEL%" NEQ "0" (
ECHO Error: Unable to create dart snapshot for flutter tool.
SET exit_code=%ERRORLEVEL%

3
dev/bots/test.dart
View File

@ -181,7 +181,6 @@ Future<void> _runToolTests() async {
await _buildRunnerTest(
path.join(flutterRoot, 'packages', 'flutter_tools'),
flutterRoot,
enableFlutterToolAsserts: true,
tableData: bigqueryApi?.tabledata,
);
@ -713,4 +712,4 @@ Future<void> _integrationTestsAndroidSdk() async {
}
// note: this also covers plugin_test_win as long as Windows has an Android SDK available.
await _runDevicelabTest('plugin_test', env: env);
}
}

2
packages/flutter_tools/lib/executable.dart
View File

@ -38,6 +38,7 @@ import 'src/commands/shell_completion.dart';
import 'src/commands/stop.dart';
import 'src/commands/test.dart';
import 'src/commands/trace.dart';
import 'src/commands/train.dart';
import 'src/commands/update_packages.dart';
import 'src/commands/upgrade.dart';
import 'src/commands/version.dart';
@ -84,6 +85,7 @@ Future<void> main(List<String> args) async {
StopCommand(),
TestCommand(verboseHelp: verboseHelp),
TraceCommand(),
TrainingCommand(),
UpdatePackagesCommand(hidden: !verboseHelp),
UpgradeCommand(),
VersionCommand(),

27
packages/flutter_tools/lib/src/commands/train.dart Normal file
View File

@ -0,0 +1,27 @@
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import '../runner/flutter_command.dart';
/// This command is run when generating the app-jit snapshot for the tool, so it cannot access the Cache
/// or any artifacts that haven't been downloaded yet.
class TrainingCommand extends FlutterCommand {
@override
String get description => 'training run for app-jit snapshot';
@override
String get name => 'training';
@override
bool get hidden => true;
@override
bool get shouldUpdateCache => false;
@override
Future<FlutterCommandResult> runCommand() async {
// This command does not do anything yet :).
return null;
}
}