firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when painting empty tables (#17952)

Browse Source
This commit is contained in:
Ian Hickson 2018-05-31 22:47:25 -07:00 committed by GitHub
parent 4aa4c965cc
commit 72c459bcfc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/rendering/table.dart
View File

@ -1119,8 +1119,10 @@ class RenderTable extends RenderBox {
void paint(PaintingContext context, Offset offset) { void paint(PaintingContext context, Offset offset) {
assert(_children.length == rows * columns); assert(_children.length == rows * columns);
if (rows * columns == 0) { if (rows * columns == 0) {
final Rect borderRect = new Rect.fromLTWH(offset.dx, offset.dy, size.width, 0.0); if (border != null) {
border.paint(context.canvas, borderRect, rows: const <double>[], columns: const <double>[]); final Rect borderRect = new Rect.fromLTWH(offset.dx, offset.dy, size.width, 0.0);
border.paint(context.canvas, borderRect, rows: const <double>[], columns: const <double>[]);
}
return; return;
} }
assert(_rowTops.length == rows + 1); assert(_rowTops.length == rows + 1);

8
packages/flutter/test/widgets/table_test.dart
View File

@ -19,6 +19,14 @@ class TestStatefulWidgetState extends State<TestStatefulWidget> {
} }
void main() { void main() {
testWidgets('Table widget - empty', (WidgetTester tester) async {
await tester.pumpWidget(
new Directionality(
textDirection: TextDirection.ltr,
child: new Table(),
),
);
});
testWidgets('Table widget - control test', (WidgetTester tester) async { testWidgets('Table widget - control test', (WidgetTester tester) async {
Future<Null> run(TextDirection textDirection) async { Future<Null> run(TextDirection textDirection) async {
await tester.pumpWidget( await tester.pumpWidget(