firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] refactor license collector (#128748)

Browse Source 
Improve debugging for https://github.com/flutter/flutter/issues/128680

In the linked issue, I cannot explain how we are getting a type error. However, this refactor eliminates the null check operator (by iterating over `MapEntries` rather than the keys) in hopes that there will be a more descriptive error in the future. The correctness of this change is verified by the existing tests in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/license_collector_test.dart
This commit is contained in:
Christopher Fujino 2023-06-15 13:25:19 -07:00 committed by GitHub
parent f8e8d89b85
commit 735fc29622
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter_tools/lib/src/license_collector.dart
View File

@ -82,11 +82,10 @@ class LicenseCollector {
}
}
final List<String> combinedLicensesList = packageLicenses.keys
.map<String>((String license) {
final List<String> packageNames = packageLicenses[license]!.toList()
..sort();
return '${packageNames.join('\n')}\n\n$license';
final List<String> combinedLicensesList = packageLicenses.entries
.map<String>((MapEntry<String, Set<String>> entry) {
final List<String> packageNames = entry.value.toList()..sort();
return '${packageNames.join('\n')}\n\n${entry.key}';
}).toList();
combinedLicensesList.sort();