firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent overflow of pagination bar with Ahem font (#7977)

Browse Source 
Once engine commit d49a6b110bced49fa318b0dd45bf409218df9ee5 rolls into
Flutter rolls in, we get correct font metrics for the Ahem font, used in
headless sky_shell test runs. Ahem has much wider glyphs than the system
font, which causes the PaginatedDataTable bottom bar to be much wider
and overflow the previous and next controls offscreen.

This commit reduces the number of rows such that the prev/next controls
are still just barely onscreen.
This commit is contained in:
Chris Bracken 2017-02-08 12:29:15 -08:00 committed by GitHub
parent 428023ceeb
commit 7425940d5b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/test/material/paginated_data_table_test.dart
View File

@ -32,7 +32,7 @@ class TestDataSource extends DataTableSource {
} }
@override @override
int get rowCount => 500 * kDesserts.length; int get rowCount => 50 * kDesserts.length;
@override @override
bool get isRowCountApproximate => false; bool get isRowCountApproximate => false;