firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chromebot recipe instructions missing a step (#26337)

Browse Source
This commit is contained in:
xster 2019-01-10 02:42:07 -08:00 committed by GitHub
parent b16ef489e0
commit 77512a3c46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev/bots/README.md
View File

@ -77,16 +77,17 @@ The typical cycle for editing a recipe is:
1. Make your edits (probably to files in 1. Make your edits (probably to files in
`//chrome_infra/build/scripts/slave/recipes/flutter`). `//chrome_infra/build/scripts/slave/recipes/flutter`).
2. Update the tests. Run `build/scripts/slave/recipes.py --use-bootstrap test 1. Update the tests. Run `build/scripts/slave/recipes.py --use-bootstrap test
train` to update existing expected output to match the new output. Verify train` to update existing expected output to match the new output. Verify
completely new test cases by altering the `GenTests` method of the recipe. completely new test cases by altering the `GenTests` method of the recipe.
The recipe is required to have 100% test coverage. The recipe is required to have 100% test coverage.
3. Run `build/scripts/slave/recipes.py run flutter/<repo> slavename=<slavename> 1. Run `build/scripts/slave/recipes.py run flutter/<repo> slavename=<slavename>
mastername=client.flutter buildername=<buildername> buildnumber=1234` where `<repo>` is one mastername=client.flutter buildername=<buildername> buildnumber=1234` where `<repo>` is one
of `flutter` or `engine`, and `slavename` and `buildername` can be looked up of `flutter` or `engine`, and `slavename` and `buildername` can be looked up
from the *Build Properties* section of a [recent from the *Build Properties* section of a [recent
build](https://build.chromium.org/p/client.flutter/one_line_per_build). build](https://build.chromium.org/p/client.flutter/one_line_per_build).
4. Upload the patch (`git commit`, `git cl upload`) and send it to someone in 1. To submit a CL, you need a local branch first (`git checkout -b [some branch name]`).
1. Upload the patch (`git commit`, `git cl upload`) and send it to someone in
the `recipes/flutter/OWNERS` file for review. the `recipes/flutter/OWNERS` file for review.
### Editing the client.flutter buildbot master ### Editing the client.flutter buildbot master