firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add const constructor to TextInputFormatter (#116654)

Browse Source 
* Add const constructor to TextInputFormatter

* Fix test

* Add abstract

* Add noSuchMethod

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>

* Add @override and void

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>

* Fix text and position of test

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>

Signed-off-by: Shogo Hida <shogo.hida@gmail.com>
This commit is contained in:
Shogo Hida 2023-01-18 09:55:33 +09:00 committed by GitHub
parent 0eaa83ad63
commit 780563ce05
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/lib/src/services/text_formatter.dart
View File

@ -88,6 +88,9 @@ enum MaxLengthEnforcement {
/// * [FilteringTextInputFormatter], a provided formatter for filtering /// * [FilteringTextInputFormatter], a provided formatter for filtering
/// characters. /// characters.
abstract class TextInputFormatter { abstract class TextInputFormatter {
/// This constructor enables subclasses to provide const constructors so that they can be used in const expressions.
const TextInputFormatter();
/// Called when text is being typed or cut/copy/pasted in the [EditableText]. /// Called when text is being typed or cut/copy/pasted in the [EditableText].
/// ///
/// You can override the resulting text based on the previous text value and /// You can override the resulting text based on the previous text value and

16
packages/flutter/test/services/text_formatter_test.dart
View File

@ -6,10 +6,26 @@ import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart'; import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart'; import 'package:flutter_test/flutter_test.dart';
class TestTextInputFormatter extends TextInputFormatter {
const TestTextInputFormatter();
@override
void noSuchMethod(Invocation invocation) {
super.noSuchMethod(invocation);
}
}
void main() { void main() {
TextEditingValue testOldValue = TextEditingValue.empty; TextEditingValue testOldValue = TextEditingValue.empty;
TextEditingValue testNewValue = TextEditingValue.empty; TextEditingValue testNewValue = TextEditingValue.empty;
test('test const constructor', () {
const TestTextInputFormatter testValue1 = TestTextInputFormatter();
const TestTextInputFormatter testValue2 = TestTextInputFormatter();
expect(testValue1, same(testValue2));
});
test('withFunction wraps formatting function', () { test('withFunction wraps formatting function', () {
testOldValue = TextEditingValue.empty; testOldValue = TextEditingValue.empty;
testNewValue = TextEditingValue.empty; testNewValue = TextEditingValue.empty;