firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter] use engine provided frame number (#82934)

Browse Source
This commit is contained in:
Jonah Williams 2021-05-20 13:29:03 -07:00 committed by GitHub
parent 25fa2e6c27
commit 78a96b09d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter/lib/src/scheduler/binding.dart
View File

@ -202,12 +202,8 @@ mixin SchedulerBinding on BindingBase {
_instance = this; _instance = this;
if (!kReleaseMode) { if (!kReleaseMode) {
int frameNumber = 0;
addTimingsCallback((List<FrameTiming> timings) { addTimingsCallback((List<FrameTiming> timings) {
for (final FrameTiming frameTiming in timings) { timings.forEach(_profileFramePostEvent);
frameNumber += 1;
_profileFramePostEvent(frameNumber, frameTiming);
}
}); });
} }
} }
@ -1103,9 +1099,9 @@ mixin SchedulerBinding on BindingBase {
} }
} }
void _profileFramePostEvent(int frameNumber, FrameTiming frameTiming) { void _profileFramePostEvent(FrameTiming frameTiming) {
postEvent('Flutter.Frame', <String, dynamic>{ postEvent('Flutter.Frame', <String, dynamic>{
'number': frameNumber, 'number': frameTiming.frameNumber,
'startTime': frameTiming.timestampInMicroseconds(FramePhase.buildStart), 'startTime': frameTiming.timestampInMicroseconds(FramePhase.buildStart),
'elapsed': frameTiming.totalSpan.inMicroseconds, 'elapsed': frameTiming.totalSpan.inMicroseconds,
'build': frameTiming.buildDuration.inMicroseconds, 'build': frameTiming.buildDuration.inMicroseconds,

3
packages/flutter/test/scheduler/scheduler_test.dart
View File

@ -143,13 +143,14 @@ void main() {
buildFinish: 15000, buildFinish: 15000,
rasterStart: 16000, rasterStart: 16000,
rasterFinish: 20000, rasterFinish: 20000,
frameNumber: 1991
)]); )]);
final List<Map<String, dynamic>> events = scheduler.getEventsDispatched('Flutter.Frame'); final List<Map<String, dynamic>> events = scheduler.getEventsDispatched('Flutter.Frame');
expect(events, hasLength(1)); expect(events, hasLength(1));
final Map<String, dynamic> event = events.first; final Map<String, dynamic> event = events.first;
expect(event['number'], isNonNegative); expect(event['number'], 1991);
expect(event['startTime'], 10000); expect(event['startTime'], 10000);
expect(event['elapsed'], 15000); expect(event['elapsed'], 15000);
expect(event['build'], 5000); expect(event['build'], 5000);